Skip to content

Commit b63536c

Browse files
BrennanConroycaptainsafia
authored andcommitted
Skip H2Spec 6.9.2/2 (#58430)
1 parent 0ac4f67 commit b63536c

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecTests.cs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
6161
get
6262
{
6363
var dataset = new TheoryData<H2SpecTestCase>();
64+
// { Test name, Skip Reason }
65+
var toSkip = new Dictionary<string, string>
66+
{
67+
{ "http2/6.9.2/2", "https://github.com/dotnet/aspnetcore/issues/47452" }
68+
};
6469

6570
var testCases = H2SpecCommands.EnumerateTestCases();
6671

@@ -77,11 +82,18 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
7782

7883
foreach (var testcase in testCases)
7984
{
85+
string skip = null;
86+
if (toSkip.TryGetValue(testcase.Item1, out var skipReason))
87+
{
88+
skip = skipReason;
89+
}
90+
8091
dataset.Add(new H2SpecTestCase
8192
{
8293
Id = testcase.Item1,
8394
Description = testcase.Item2,
8495
Https = false,
96+
Skip = skip,
8597
});
8698

8799
// https://github.com/dotnet/aspnetcore/issues/11301 We should use Skip but it's broken at the moment.
@@ -92,6 +104,7 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
92104
Id = testcase.Item1,
93105
Description = testcase.Item2,
94106
Https = true,
107+
Skip = skip,
95108
});
96109
}
97110
}

0 commit comments

Comments
 (0)