Skip to content

Commit b6ff5fb

Browse files
committed
Use the new RPM tooling and build debs/rpms in the regular build step (instead of as separate steps)
1 parent b1b144d commit b6ff5fb

File tree

4 files changed

+24
-80
lines changed

4 files changed

+24
-80
lines changed

.azure/pipelines/ci-public.yml

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,6 @@ variables:
7979
value: true
8080
- template: /eng/common/templates/variables/pool-providers.yml
8181

82-
resources:
83-
containers:
84-
- container: debpkg
85-
image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-debpkg
86-
87-
- container: rpmpkg
88-
image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-fpm
89-
9082
stages:
9183
- stage: build
9284
displayName: Build
@@ -313,43 +305,13 @@ stages:
313305
--ci
314306
--arch x64
315307
--pack
308+
--build-installers
316309
--all
317310
--no-build-java
318311
-p:OnlyPackPlatformSpecificPackages=true
319312
$(_BuildArgs)
320313
$(_InternalRuntimeDownloadArgs)
321314
displayName: Run build.sh
322-
- script: ./eng/build.sh
323-
--ci
324-
--nobl
325-
--arch x64
326-
--build-installers
327-
--no-build-deps
328-
--no-build-nodejs
329-
-p:OnlyPackPlatformSpecificPackages=true
330-
-p:BuildRuntimeArchive=false
331-
-p:LinuxInstallerType=deb
332-
$(_BuildArgs)
333-
$(_InternalRuntimeDownloadArgs)
334-
displayName: Build Debian installers
335-
target: debpkg
336-
- script: ./eng/build.sh
337-
--ci
338-
--nobl
339-
--arch x64
340-
--build-installers
341-
--no-build-deps
342-
--no-build-nodejs
343-
--publish
344-
-p:OnlyPackPlatformSpecificPackages=true
345-
-p:BuildRuntimeArchive=false
346-
-p:LinuxInstallerType=rpm
347-
-p:AssetManifestFileName=aspnetcore-Linux_x64.xml
348-
$(_BuildArgs)
349-
$(_PublishArgs)
350-
$(_InternalRuntimeDownloadArgs)
351-
displayName: Build RPM installers
352-
target: rpmpkg
353315
artifacts:
354316
- name: Linux_x64_Logs_Attempt_$(System.JobAttempt)
355317
path: artifacts/log/

.azure/pipelines/ci.yml

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,6 @@ variables:
121121
- template: /eng/common/templates-official/variables/pool-providers.yml@self
122122

123123
resources:
124-
containers:
125-
- container: debpkg
126-
image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-debpkg
127-
128-
- container: rpmpkg
129-
image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-fpm
130124
repositories:
131125
# Repo: 1ESPipelineTemplates/1ESPipelineTemplates
132126
- repository: 1esPipelines
@@ -383,42 +377,12 @@ extends:
383377
--arch x64
384378
--pack
385379
--all
380+
--build-installers
386381
--no-build-java
387382
-p:OnlyPackPlatformSpecificPackages=true
388383
$(_BuildArgs)
389384
$(_InternalRuntimeDownloadArgs)
390385
displayName: Run build.sh
391-
- script: ./eng/build.sh
392-
--ci
393-
--nobl
394-
--arch x64
395-
--build-installers
396-
--no-build-deps
397-
--no-build-nodejs
398-
-p:OnlyPackPlatformSpecificPackages=true
399-
-p:BuildRuntimeArchive=false
400-
-p:LinuxInstallerType=deb
401-
$(_BuildArgs)
402-
$(_InternalRuntimeDownloadArgs)
403-
displayName: Build Debian installers
404-
target: debpkg
405-
- script: ./eng/build.sh
406-
--ci
407-
--nobl
408-
--arch x64
409-
--build-installers
410-
--no-build-deps
411-
--no-build-nodejs
412-
--publish
413-
-p:OnlyPackPlatformSpecificPackages=true
414-
-p:BuildRuntimeArchive=false
415-
-p:LinuxInstallerType=rpm
416-
-p:AssetManifestFileName=aspnetcore-Linux_x64.xml
417-
$(_BuildArgs)
418-
$(_PublishArgs)
419-
$(_InternalRuntimeDownloadArgs)
420-
displayName: Build RPM installers
421-
target: rpmpkg
422386
artifacts:
423387
- name: Linux_x64_Logs_Attempt_$(System.JobAttempt)
424388
path: artifacts/log/

src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.sfxproj

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@
3030
</PropertyGroup>
3131

3232
<PropertyGroup Condition="'$(BuildInstallers)' == 'true'">
33-
<BuildDebPackage Condition="'$(RuntimeIdentifier)' == 'linux-x64' and '$(LinuxInstallerType)' == 'deb'">true</BuildDebPackage>
34-
<BuildRpmPackage Condition="('$(RuntimeIdentifier)' == 'linux-x64' or '$(RuntimeIdentifier)' == 'linux-arm64') and '$(LinuxInstallerType)' == 'rpm'">true</BuildRpmPackage>
33+
<BuildDebPackage Condition="'$(RuntimeIdentifier)' == 'linux-x64'">true</BuildDebPackage>
34+
<BuildRpmPackage Condition="'$(RuntimeIdentifier)' == 'linux-x64' or '$(RuntimeIdentifier)' == 'linux-arm64'">true</BuildRpmPackage>
35+
<UseArcadeRpmTooling>true</UseArcadeRpmTooling>
3536
</PropertyGroup>
3637

3738
<ItemGroup>
@@ -171,4 +172,15 @@
171172
Targets="PublishToDisk"
172173
Properties="OutputPath=$(TargetingPackLayoutRoot)" />
173174
</Target>
175+
176+
<Target Name="AddLinuxPackageInformation" BeforeTargets="GetDebInstallerJsonProperties;GetRpmInstallerJsonProperties">
177+
<ItemGroup>
178+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/packs/Microsoft.AspNetCore.App.Ref" />
179+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/packs/Microsoft.AspNetCore.App.Ref/$(Version)" />
180+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/packs/Microsoft.AspNetCore.App.Ref/$(Version)/data" />
181+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/packs/Microsoft.AspNetCore.App.Ref/$(Version)/analyzers" />
182+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/packs/Microsoft.AspNetCore.App.Ref/$(Version)/ref" />
183+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/packs/Microsoft.AspNetCore.App.Ref/$(Version)/ref/$(TargetFramework)" />
184+
</ItemGroup>
185+
</Target>
174186
</Project>

src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
</PropertyGroup>
4343

4444
<PropertyGroup Condition="'$(BuildInstallers)' == 'true'">
45-
<BuildDebPackage Condition="'$(RuntimeIdentifier)' == 'linux-x64' and '$(LinuxInstallerType)' == 'deb'">true</BuildDebPackage>
46-
<BuildRpmPackage Condition="('$(RuntimeIdentifier)' == 'linux-x64' or '$(RuntimeIdentifier)' == 'linux-arm64') and '$(LinuxInstallerType)' == 'rpm'">true</BuildRpmPackage>
45+
<BuildDebPackage Condition="'$(RuntimeIdentifier)' == 'linux-x64'">true</BuildDebPackage>
46+
<BuildRpmPackage Condition="'$(RuntimeIdentifier)' == 'linux-x64' or '$(RuntimeIdentifier)' == 'linux-arm64'">true</BuildRpmPackage>
4747
</PropertyGroup>
4848

4949
<ItemGroup>
@@ -96,4 +96,10 @@
9696
</Target>
9797

9898
<Target Name="ReturnProductVersion" Returns="$(Version)" />
99+
100+
<Target Name="AddLinuxPackageInformation" BeforeTargets="GetDebInstallerJsonProperties;GetRpmInstallerJsonProperties">
101+
<ItemGroup>
102+
<RpmOwnedDirectory Include="$(LinuxInstallRoot)/shared/Microsoft.AspNetCore.App;$(LinuxInstallRoot)/shared/Microsoft.AspNetCore.App/$(Version)" />
103+
</ItemGroup>
104+
</Target>
99105
</Project>

0 commit comments

Comments
 (0)