PR feedback

MackinnonBuck · MackinnonBuck · commit beecc323fb4a · 2025-06-09T14:05:43.000-04:00
diff --git a/src/Identity/Core/src/Passkeys/BufferSourceJsonConverter.cs b/src/Identity/Core/src/Passkeys/BufferSourceJsonConverter.cs
@@ -89,5 +89,11 @@ private static void WriteBase64UrlStringValue(Utf8JsonWriter writer, ReadOnlySpa
 
         var base64UrlUtf8 = byteSpan[..bytesWritten];
         writer.WriteStringValue(base64UrlUtf8);
+
+        if (pooledArray != null)
+        {
+            byteSpan.Clear();
+            ArrayPool<byte>.Shared.Return(pooledArray);
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -89,5 +89,11 @@ private static void WriteBase64UrlStringValue(Utf8JsonWriter writer, ReadOnlySpa`
`89`	`89`
`90`	`90`	`var base64UrlUtf8 = byteSpan[..bytesWritten];`
`91`	`91`	`writer.WriteStringValue(base64UrlUtf8);`
	`92`	`+`
	`93`	`+ if (pooledArray != null)`
	`94`	`+ {`
	`95`	`+ byteSpan.Clear();`
	`96`	`+ ArrayPool<byte>.Shared.Return(pooledArray);`
	`97`	`+ }`
`92`	`98`	`}`
`93`	`99`	`}`