Change accessibility checks

Author: captainsafia

src/OpenApi/gen/Helpers/AssemblyTypeSymbolsVisitor.cs

@@ -4,7 +4,6 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Threading;
-using Microsoft.AspNetCore.OpenApi.SourceGenerators.Xml;
 using Microsoft.CodeAnalysis;
 
 namespace Microsoft.AspNetCore.OpenApi.SourceGenerators;
@@ -45,7 +44,7 @@ public override void VisitNamedType(INamedTypeSymbol type)
     {
         _cancellationToken.ThrowIfCancellationRequested();
 
-        if (!IsDeclaredInAssembly(type) || !type.IsAccessibleType() || !_exportedTypes.Add(type))
+        if (!IsDeclaredInAssembly(type) || !_exportedTypes.Add(type))
         {
             return;
         }
@@ -62,7 +61,7 @@ public override void VisitNamedType(INamedTypeSymbol type)
         foreach (var property in properties)
         {
             _cancellationToken.ThrowIfCancellationRequested();
-            if (IsDeclaredInAssembly(property) && property.IsAccessibleType() && _exportedProperties.Add(property))
+            if (IsDeclaredInAssembly(property) && _exportedProperties.Add(property))
             {
                 property.Type.Accept(this);
             }
@@ -71,7 +70,7 @@ public override void VisitNamedType(INamedTypeSymbol type)
         foreach (var method in methods)
         {
             _cancellationToken.ThrowIfCancellationRequested();
-            if (IsDeclaredInAssembly(method) && method.IsAccessibleType() && _exportedMethods.Add(method))
+            if (IsDeclaredInAssembly(method) && _exportedMethods.Add(method))
             {
                 method.Accept(this);
             }

src/OpenApi/gen/XmlCommentGenerator.Parser.cs

@@ -92,7 +92,9 @@ public sealed partial class XmlCommentGenerator
         foreach (var (name, value) in input.RawComments)
         {
             if (DocumentationCommentId.GetFirstSymbolForDeclarationId(name, compilation) is ISymbol symbol &&
-                symbol.IsAccessibleType() &&
+                // Only include symbols that are declared in the application assembly or are
+                // accessible from the application assembly.
+                (SymbolEqualityComparer.Default.Equals(symbol.ContainingAssembly, input.Compilation.Assembly) || symbol.IsAccessibleType()) &&
                 // Skip static classes that are just containers for members with annotations
                 // since they cannot be instantiated.
                 symbol is not INamedTypeSymbol { TypeKind: TypeKind.Class, IsStatic: true })

src/OpenApi/sample/Controllers/TestController.cs

@@ -40,7 +40,7 @@ public class RouteParamsContainer
         [FromRoute]
         [MinLength(5)]
         [UnconditionalSuppressMessage("Trimming", "IL2026:RequiresUnreferencedCode", Justification = "MinLengthAttribute works without reflection on string properties.")]
-        public string Name { get; set; }
+        public string? Name { get; set; }
     }
 
     public record MvcTodo(string Title, string Description, bool IsCompleted);

src/OpenApi/sample/Sample.csproj

@@ -2,8 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
-    <!-- Disable to match nullability annotations in test environment. -->
-    <Nullable>disable</Nullable>
+    <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <!-- Required to generated trimmable Map-invocations. -->
     <EnableRequestDelegateGenerator>true</EnableRequestDelegateGenerator>
@@ -25,6 +24,11 @@
     <Reference Include="Microsoft.AspNetCore.Mvc" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Compile Include="../test/Microsoft.AspNetCore.OpenApi.Tests/Shared/SharedTypes.cs" />
+    <Compile Include="../test/Microsoft.AspNetCore.OpenApi.Tests/Shared/SharedTypes.Polymorphism.cs" />
+  </ItemGroup>
+
   <!-- Required to generated trimmable Map-invocations. -->
   <ItemGroup>
     <ProjectReference Include="$(RepoRoot)/src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.RequestDelegateGenerator/Microsoft.AspNetCore.Http.RequestDelegateGenerator.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />

src/OpenApi/sample/Shared/SharedTypes.DeeplyNestedType.cs

@@ -118,12 +118,10 @@
         "type": "object",
         "properties": {
           "title": {
-            "type": "string",
-            "nullable": true
+            "type": "string"
           },
           "description": {
-            "type": "string",
-            "nullable": true
+            "type": "string"
           },
           "isCompleted": {
             "type": "boolean"

src/OpenApi/test/Microsoft.AspNetCore.OpenApi.Tests/Integration/snapshots/OpenApi3_0/OpenApiDocumentIntegrationTests.VerifyOpenApiDocument_documentName=controllers.verified.txt

@@ -145,6 +145,9 @@
           "content": {
             "multipart/form-data": {
               "schema": {
+                "required": [
+                  "file"
+                ],
                 "type": "object",
                 "allOf": [
                   {
@@ -200,7 +203,6 @@
           },
           "title": {
             "type": "string",
-            "nullable": true,
             "description": "The title of the to-do item."
           },
           "completed": {

src/OpenApi/test/Microsoft.AspNetCore.OpenApi.Tests/Integration/snapshots/OpenApi3_0/OpenApiDocumentIntegrationTests.VerifyOpenApiDocument_documentName=forms.verified.txt

@@ -123,8 +123,7 @@
             "format": "double"
           },
           "color": {
-            "type": "string",
-            "nullable": true
+            "type": "string"
           },
           "sides": {
             "type": "integer",
@@ -145,8 +144,7 @@
             "format": "double"
           },
           "color": {
-            "type": "string",
-            "nullable": true
+            "type": "string"
           },
           "sides": {
             "type": "integer",
@@ -170,7 +168,6 @@
           },
           "title": {
             "type": "string",
-            "nullable": true,
             "description": "The title of the to-do item."
           },
           "completed": {
@@ -193,8 +190,7 @@
             "format": "double"
           },
           "color": {
-            "type": "string",
-            "nullable": true
+            "type": "string"
           },
           "sides": {
             "type": "integer",