review comments - part 1

Author: ladeak

src/Servers/Kestrel/Core/src/Internal/Http2/FlowControl/InputFlowControl.cs

@@ -49,19 +49,19 @@ public InputFlowControl(uint initialWindowSize, uint minWindowSizeIncrement)
     {
         Debug.Assert(initialWindowSize >= minWindowSizeIncrement, "minWindowSizeIncrement is greater than the window size.");
 
-        _flow = new FlowControlState(initialWindowSize, false);
+        _flow = new FlowControlState(initialWindowSize, isAborted: false);
         _initialWindowSize = initialWindowSize;
         _minWindowSizeIncrement = (int)minWindowSizeIncrement;
     }
 
     public bool IsAvailabilityLow => _flow.Available < _minWindowSizeIncrement;
 
-    // Test hook, not participating in mutual exclusion
+    // Test hook
     internal uint Available => _flow.Available;
 
     public void Reset()
     {
-        _flow = new FlowControlState(_initialWindowSize, false);
+        _flow = new FlowControlState(_initialWindowSize, isAborted: false);
         _pendingUpdateSize = 0;
         _windowUpdatesDisabled = false;
     }
@@ -103,13 +103,11 @@ public bool TryUpdateWindow(int bytes, out int updateSize)
                 return false;
             }
 
-            var maxUpdate = int.MaxValue - currentFlow.Available;
-            if (bytes > maxUpdate)
-            {
-                // We only try to update the window back to its initial size after the app consumes data.
-                // It shouldn't be possible for the window size to ever exceed Http2PeerSettings.MaxWindowSize.
-                Debug.Assert(false, $"{nameof(TryUpdateWindow)} attempted to grow window past max size.");
-            }
+            var maxUpdate = Http2PeerSettings.MaxWindowSize - currentFlow.Available;
+
+            // We only try to update the window back to its initial size after the app consumes data.
+            // It shouldn't be possible for the window size to ever exceed Http2PeerSettings.MaxWindowSize.
+            Debug.Assert(bytes <= maxUpdate, $"{nameof(TryUpdateWindow)} attempted to grow window past max size.");
             computedFlow = new FlowControlState(currentFlow.Available + (uint)bytes, isAborted: false);
         } while (currentFlow._state != Interlocked.CompareExchange(ref _flow._state, computedFlow._state, currentFlow._state));