Skip to content

Commit cd5121c

Browse files
authored
Suppress CP1002 temporarily via NoWarn
The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK.
1 parent fc7d7fc commit cd5121c

15 files changed

+16
-75
lines changed

src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
<GenerateDocumentationFile>true</GenerateDocumentationFile>
77
<PackageTags>cache;distributedcache;sqlserver</PackageTags>
88
<ExcludeFromSourceOnlyBuild>true</ExcludeFromSourceOnlyBuild>
9-
<NoWarn>$(NoWarn);PKG0001</NoWarn>
9+
<!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
10+
<NoWarn>$(NoWarn);PKG0001;CP1002</NoWarn>
1011
<IsPackable>true</IsPackable>
1112
<IsShipping>true</IsShipping>
1213
</PropertyGroup>

src/DataProtection/DataProtection/src/CompatibilitySuppressions.xml

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
<Nullable>annotations</Nullable>
1313
<Nullable Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'">enable</Nullable>
1414
<IsTrimmable>true</IsTrimmable>
15+
<!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
16+
<NoWarn>$(NoWarn);CP1002</NoWarn>
1517
</PropertyGroup>
1618

1719
<ItemGroup>

src/DataProtection/Extensions/src/CompatibilitySuppressions.xml

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/DataProtection/Extensions/src/Microsoft.AspNetCore.DataProtection.Extensions.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
<GenerateDocumentationFile>true</GenerateDocumentationFile>
99
<PackageTags>aspnetcore;dataprotection</PackageTags>
1010
<IsTrimmable>true</IsTrimmable>
11+
<!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
12+
<NoWarn>$(NoWarn);CP1002</NoWarn>
1113
</PropertyGroup>
1214

1315
<ItemGroup>

src/DataProtection/StackExchangeRedis/src/CompatibilitySuppressions.xml

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/DataProtection/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
<GenerateDocumentationFile>true</GenerateDocumentationFile>
88
<PackageTags>aspnetcore;dataprotection;redis</PackageTags>
99
<IsTrimmable>true</IsTrimmable>
10+
<!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
11+
<NoWarn>$(NoWarn);CP1002</NoWarn>
1012
</PropertyGroup>
1113

1214
<ItemGroup>

src/Features/JsonPatch/src/CompatibilitySuppressions.xml

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
<GenerateDocumentationFile>true</GenerateDocumentationFile>
99
<PackageTags>aspnetcore;json;jsonpatch</PackageTags>
1010
<Nullable>disable</Nullable>
11+
<!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
12+
<NoWarn>$(NoWarn);CP1002</NoWarn>
1113
</PropertyGroup>
1214

1315
<ItemGroup>

src/FileProviders/Embedded/src/CompatibilitySuppressions.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
3-
<Suppression>
4-
<DiagnosticId>CP1002</DiagnosticId>
5-
<Target>SMDiagnostics.dll</Target>
6-
</Suppression>
7-
<Suppression>
8-
<DiagnosticId>CP1002</DiagnosticId>
9-
<Target>System.ServiceModel.Internals.dll</Target>
10-
</Suppression>
113
<Suppression>
124
<DiagnosticId>CP1003</DiagnosticId>
135
<Target>lib/net7.0/Microsoft.Extensions.FileProviders.Embedded.dll</Target>

0 commit comments

Comments
 (0)