Skip to content

Commit d086eec

Browse files
captainsafiawtgodbe
authored andcommitted
Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open (#59112)
* Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open * Use if-def from base class * Fix in-proc and remove attributes from abstract class
1 parent c700eda commit d086eec

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketInProcessTests.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
2222

2323
[Collection(IISTestSiteCollectionInProc.Name)]
2424
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
25-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
25+
#if IISEXPRESS_FUNCTIONALS
26+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
27+
#else
28+
// These queues do not have websockets enabled currently for full IIS
29+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
30+
#endif
2631
public class WebSocketsInProcessTests : WebSocketsTests
2732
{
2833
public WebSocketsInProcessTests(IISTestSiteFixture fixture, ITestOutputHelper testOutput) : base(fixture, testOutput)

src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketOutOfProcessTests.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
2222

2323
[Collection(IISTestSiteCollectionOutOfProc.Name)]
2424
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
25-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
25+
#if IISEXPRESS_FUNCTIONALS
26+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
27+
#else
28+
// These queues do not have websockets enabled currently for full IIS
29+
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
30+
#endif
2631
public class WebSocketsOutOfProcessTests : WebSocketsTests
2732
{
2833
public WebSocketsOutOfProcessTests(IISTestSiteFixture fixture, ITestOutputHelper testOutput) : base(fixture, testOutput)

src/Servers/IIS/IIS/test/Common.FunctionalTests/WebSocketTests.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ namespace Microsoft.AspNetCore.Server.IIS.NewShim.FunctionalTests;
2727
namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
2828
#endif
2929

30-
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8, SkipReason = "No WebSocket supported on Win7")]
31-
#if IISEXPRESS_FUNCTIONALS
32-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open")]
33-
#else
34-
// These queues do not have websockets enabled currently for full IIS
35-
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;Windows.Amd64.Server2022.Open")]
36-
#endif
3730
public abstract class WebSocketsTests : FunctionalTestsBase
3831
{
3932
public IISTestSiteFixture Fixture { get; }

0 commit comments

Comments
 (0)