PR feedback

Author: JamesNK

src/Servers/Connections.Abstractions/src/IMemoryPoolFactory.cs

@@ -15,5 +15,5 @@ public interface IMemoryPoolFactory<T>
     /// </summary>
     /// <param name="options">Options for configuring the memory pool.</param>
     /// <returns>A new memory pool instance.</returns>
-    MemoryPool<T> Create(MemoryPoolOptions options);
+    MemoryPool<T> Create(MemoryPoolOptions? options = null);
 }

src/Servers/Connections.Abstractions/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt

@@ -1,6 +1,6 @@
 #nullable enable
 Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>
-Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions! options) -> System.Buffers.MemoryPool<T>!
+Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions? options = null) -> System.Buffers.MemoryPool<T>!
 Microsoft.AspNetCore.Connections.MemoryPoolOptions
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.MemoryPoolOptions() -> void
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.Owner.get -> string?

src/Servers/Connections.Abstractions/src/PublicAPI/net462/PublicAPI.Unshipped.txt

@@ -1,6 +1,6 @@
 #nullable enable
 Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>
-Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions! options) -> System.Buffers.MemoryPool<T>!
+Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions? options = null) -> System.Buffers.MemoryPool<T>!
 Microsoft.AspNetCore.Connections.MemoryPoolOptions
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.MemoryPoolOptions() -> void
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.Owner.get -> string?

src/Servers/Connections.Abstractions/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt

@@ -1,6 +1,6 @@
 #nullable enable
 Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>
-Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions! options) -> System.Buffers.MemoryPool<T>!
+Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions? options = null) -> System.Buffers.MemoryPool<T>!
 Microsoft.AspNetCore.Connections.MemoryPoolOptions
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.MemoryPoolOptions() -> void
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.Owner.get -> string?

src/Servers/Connections.Abstractions/src/PublicAPI/netstandard2.1/PublicAPI.Unshipped.txt

@@ -1,6 +1,6 @@
 #nullable enable
 Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>
-Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions! options) -> System.Buffers.MemoryPool<T>!
+Microsoft.AspNetCore.Connections.IMemoryPoolFactory<T>.Create(Microsoft.AspNetCore.Connections.MemoryPoolOptions? options = null) -> System.Buffers.MemoryPool<T>!
 Microsoft.AspNetCore.Connections.MemoryPoolOptions
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.MemoryPoolOptions() -> void
 Microsoft.AspNetCore.Connections.MemoryPoolOptions.Owner.get -> string?

src/Servers/Kestrel/Core/src/Internal/PinnedBlockMemoryPoolFactory.cs

@@ -24,9 +24,9 @@ public PinnedBlockMemoryPoolFactory(MemoryPoolMetrics metrics, TimeProvider? tim
         _logger = logger;
     }
 
-    public MemoryPool<byte> Create(MemoryPoolOptions options)
+    public MemoryPool<byte> Create(MemoryPoolOptions? options = null)
     {
-        var pool = new PinnedBlockMemoryPool(options.Owner, _metrics, _logger);
+        var pool = new PinnedBlockMemoryPool(options?.Owner, _metrics, _logger);
 
         _pools.TryAdd(pool, nuint.Zero);
 

src/Servers/Kestrel/Core/test/PinnedBlockMemoryPoolFactoryTests.cs

@@ -17,17 +17,26 @@ public class PinnedBlockMemoryPoolFactoryTests
     public void CreatePool()
     {
         var factory = CreateMemoryPoolFactory();
-        var pool = factory.Create(new MemoryPoolOptions());
+        var pool = factory.Create();
         Assert.NotNull(pool);
         Assert.IsType<PinnedBlockMemoryPool>(pool);
     }
 
+    [Fact]
+    public void CreatePoolWithOwner()
+    {
+        var factory = CreateMemoryPoolFactory();
+        var pool = factory.Create(new MemoryPoolOptions { Owner = "test" });
+        Assert.NotNull(pool);
+        Assert.Equal("test", Assert.IsType<PinnedBlockMemoryPool>(pool).Owner);
+    }
+
     [Fact]
     public void CreateMultiplePools()
     {
         var factory = CreateMemoryPoolFactory();
-        var pool1 = factory.Create(new MemoryPoolOptions());
-        var pool2 = factory.Create(new MemoryPoolOptions());
+        var pool1 = factory.Create();
+        var pool2 = factory.Create();
 
         Assert.NotNull(pool1);
         Assert.NotNull(pool2);
@@ -38,7 +47,7 @@ public void CreateMultiplePools()
     public void DisposePoolRemovesFromFactory()
     {
         var factory = CreateMemoryPoolFactory();
-        var pool = factory.Create(new MemoryPoolOptions());
+        var pool = factory.Create();
         Assert.NotNull(pool);
 
         var dict = (ConcurrentDictionary<PinnedBlockMemoryPool, nuint>)(typeof(PinnedBlockMemoryPoolFactory)
@@ -57,8 +66,8 @@ public async Task FactoryHeartbeatWorks()
         var factory = CreateMemoryPoolFactory(timeProvider);
 
         // Use 2 pools to make sure they all get triggered by the heartbeat
-        var pool = Assert.IsType<PinnedBlockMemoryPool>(factory.Create(new MemoryPoolOptions()));
-        var pool2 = Assert.IsType<PinnedBlockMemoryPool>(factory.Create(new MemoryPoolOptions()));
+        var pool = Assert.IsType<PinnedBlockMemoryPool>(factory.Create());
+        var pool2 = Assert.IsType<PinnedBlockMemoryPool>(factory.Create());
 
         var blocks = new List<IMemoryOwner<byte>>();
         for (var i = 0; i < 10000; i++)

src/Servers/Kestrel/shared/DefaultSimpleMemoryPoolFactory.cs

@@ -10,7 +10,7 @@ internal sealed class DefaultSimpleMemoryPoolFactory : IMemoryPoolFactory<byte>
 {
     public static DefaultSimpleMemoryPoolFactory Instance { get; } = new DefaultSimpleMemoryPoolFactory();
 
-    public MemoryPool<byte> Create(MemoryPoolOptions options)
+    public MemoryPool<byte> Create(MemoryPoolOptions? options = null)
     {
         return MemoryPool<byte>.Shared;
     }

src/Servers/Kestrel/shared/test/TestServiceContext.cs

@@ -87,6 +87,6 @@ public WrappingMemoryPoolFactory(Func<MemoryPool<byte>> memoryPoolFactory)
             _memoryPoolFactory = memoryPoolFactory;
         }
 
-        public MemoryPool<byte> Create(MemoryPoolOptions options) => _memoryPoolFactory();
+        public MemoryPool<byte> Create(MemoryPoolOptions options = null) => _memoryPoolFactory();
     }
 }

src/Servers/Kestrel/shared/test/TransportTestHelpers/DiagnosticMemoryPoolFactory.cs

@@ -25,11 +25,11 @@ public DiagnosticMemoryPoolFactory(bool allowLateReturn = false, bool rentTracki
         _pools = new List<DiagnosticMemoryPool>();
     }
 
-    public MemoryPool<byte> Create(MemoryPoolOptions options)
+    public MemoryPool<byte> Create(MemoryPoolOptions options = null)
     {
         lock (_pools)
         {
-            var pool = new DiagnosticMemoryPool(new PinnedBlockMemoryPool(), _allowLateReturn, _rentTracking);
+            var pool = new DiagnosticMemoryPool(new PinnedBlockMemoryPool(options?.Owner), _allowLateReturn, _rentTracking);
             _pools.Add(pool);
             return pool;
         }