Improve nullable annotation on CancelInvocationMessage.InvocationId

AArnott · AArnott · commit e373af879ab2 · 2025-08-03T16:05:13.000-06:00
This declares a `new` property for `string InvocationId { get; }` so that the compiler sees it as non-nullable, consistent with the constructor declared on the same type.
diff --git a/src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs b/src/SignalR/common/SignalR.Common/src/Protocol/CancelInvocationMessage.cs
@@ -17,4 +17,7 @@ public class CancelInvocationMessage : HubInvocationMessage
     public CancelInvocationMessage(string invocationId) : base(invocationId)
     {
     }
+
+    /// <inheritdoc cref="HubInvocationMessage.InvocationId" />
+    public new string InvocationId => base.InvocationId!;
 }
diff --git a/src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt b/src/SignalR/common/SignalR.Common/src/PublicAPI/net10.0/PublicAPI.Unshipped.txt
@@ -1 +1,2 @@
 #nullable enable
+Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!
diff --git a/src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt b/src/SignalR/common/SignalR.Common/src/PublicAPI/net462/PublicAPI.Unshipped.txt
@@ -1 +1,2 @@
 #nullable enable
+Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!
diff --git a/src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt b/src/SignalR/common/SignalR.Common/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt
@@ -1 +1,2 @@
 #nullable enable
+Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!

Original file line number	Diff line number	Diff line change
`@@ -17,4 +17,7 @@ public class CancelInvocationMessage : HubInvocationMessage`
`17`	`17`	`public CancelInvocationMessage(string invocationId) : base(invocationId)`
`18`	`18`	`{`
`19`	`19`	`}`
	`20`	`+`
	`21`	`+ /// <inheritdoc cref="HubInvocationMessage.InvocationId" />`
	`22`	`+ public new string InvocationId => base.InvocationId!;`
`20`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`	`1`	`#nullable enable`
	`2`	`+Microsoft.AspNetCore.SignalR.Protocol.CancelInvocationMessage.InvocationId.get -> string!`