Skip to content

Commit ea6ae49

Browse files
Fix new tab sign in, update chrome driver (#44406)
Co-authored-by: Mackinnon Buck <[email protected]>
1 parent 2651d92 commit ea6ae49

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/BasicTestAppAuthenticationWebDriverExtensions.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,11 @@ public static void SignInAs(this IWebDriver browser, Uri baseUri, string usernam
2020
{
2121
// Some tests need to change the authentication state without discarding the
2222
// original page, but this adds several seconds of delay
23-
var javascript = (IJavaScriptExecutor)browser;
2423
var originalWindow = browser.CurrentWindowHandle;
25-
javascript.ExecuteScript("window.open()");
26-
browser.SwitchTo().Window(browser.WindowHandles.Last());
24+
browser.SwitchTo().NewWindow(WindowType.Tab);
2725
browser.Navigate(baseUri, baseRelativeUri, noReload: false);
2826
browser.Exists(By.CssSelector("h1#authentication"));
29-
javascript.ExecuteScript("window.close()");
27+
browser.Close();
3028
browser.SwitchTo().Window(originalWindow);
3129
}
3230
else

src/Shared/E2ETesting/selenium-config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"drivers": {
33
"chrome": {
4-
"version" : "103.0.5060.134"
4+
"version" : "106.0.5249.21"
55
}
66
},
77
"ignoreExtraDrivers": true

0 commit comments

Comments
 (0)