PR feedback

JamesNK · JamesNK · commit ed22208e8494 · 2025-07-24T06:04:16.000+08:00
diff --git a/src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs b/src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs
@@ -512,6 +512,8 @@ public void MapKeyBool_CaseInsensitive()
   }
 }";
 
+        // Note: JSON property names here are keys in a dictionary, not fields. So FieldNamesCaseInsensitive doesn't apply.
+        // The new serializer supports converting true/false to boolean keys while ignoring case.
         AssertReadJson<HelloRequest>(json, serializeOld: false);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -512,6 +512,8 @@ public void MapKeyBool_CaseInsensitive()`
`512`	`512`	`}`
`513`	`513`	`}";`
`514`	`514`
	`515`	`+ // Note: JSON property names here are keys in a dictionary, not fields. So FieldNamesCaseInsensitive doesn't apply.`
	`516`	`+ // The new serializer supports converting true/false to boolean keys while ignoring case.`
`515`	`517`	`AssertReadJson<HelloRequest>(json, serializeOld: false);`
`516`	`518`	`}`
`517`	`519`