Simplify error handling: combine all checks into single error message

Co-authored-by: javiercn <[email protected]>

Author: Copilot

src/Components/Components/src/PersistentState/PersistentValueProviderComponentSubscription.cs

@@ -229,24 +229,10 @@ private static PropertyGetter PropertyGetterFactory((Type type, string propertyN
     {
         var (type, propertyName) = key;
         var propertyInfo = GetPropertyInfo(type, propertyName);
-        if (propertyInfo == null)
-        {
-            // Check if the property exists but is not public to provide a better error message
-            var nonPublicProperty = type.GetProperty(propertyName, ComponentProperties.BindablePropertyFlags);
-            if (nonPublicProperty != null)
-            {
-                throw new InvalidOperationException(
-                    $"The property '{propertyName}' on component type '{type.FullName}' cannot be used with {nameof(PersistentStateAttribute)} because it is not public. Properties with {nameof(PersistentStateAttribute)} must have a public getter.");
-            }
-            
-            throw new InvalidOperationException($"Property {propertyName} not found on type {type.FullName}");
-        }
-
-        // Check if the property is public
-        if (propertyInfo.GetMethod == null || !propertyInfo.GetMethod.IsPublic)
+        if (propertyInfo == null || propertyInfo.GetMethod == null || !propertyInfo.GetMethod.IsPublic)
         {
             throw new InvalidOperationException(
-                $"The property '{propertyName}' on component type '{type.FullName}' cannot be used with {nameof(PersistentStateAttribute)} because it is not public. Properties with {nameof(PersistentStateAttribute)} must have a public getter.");
+                $"A public property '{propertyName}' on component type '{type.FullName}' with a public getter wasn't found.");
         }
 
         return new PropertyGetter(type, propertyInfo);

src/Components/Components/test/PersistentValueProviderComponentSubscriptionTests.cs

@@ -660,10 +660,9 @@ public void Constructor_ThrowsClearException_ForPrivateProperty()
             new PersistentValueProviderComponentSubscription(
                 state, componentState, cascadingParameterInfo, serviceProvider, logger));
 
-        // Should throw a clear error about non-public properties, not "Property not found"
-        Assert.Contains("not public", exception.Message);
-        Assert.Contains("PersistentState", exception.Message);
-        Assert.DoesNotContain("not found", exception.Message);
+        // Should throw a clear error about needing a public property with public getter
+        Assert.Contains("A public property", exception.Message);
+        Assert.Contains("with a public getter wasn't found", exception.Message);
     }
 
     [Fact]
@@ -684,9 +683,9 @@ public void Constructor_ThrowsClearException_ForPrivateGetter()
             new PersistentValueProviderComponentSubscription(
                 state, componentState, cascadingParameterInfo, serviceProvider, logger));
 
-        // Should throw a clear error about non-public getter
-        Assert.Contains("not public", exception.Message);
-        Assert.Contains("PersistentState", exception.Message);
+        // Should throw a clear error about needing a public property with public getter
+        Assert.Contains("A public property", exception.Message);
+        Assert.Contains("with a public getter wasn't found", exception.Message);
     }
 
     [Fact]