Skip to content

Commit f0f290d

Browse files
authored
Cleanup
1 parent bf4eb9f commit f0f290d

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

Directory.Build.props

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -195,18 +195,13 @@
195195
limitations in the way the .NET SDK finds shared frameworks and targeting packs. It allows
196196
tests to use the shared frameworks and targeting packs that were just built.
197197
198-
However, source-build needs this to not happen while building projects that rely on the
199-
AppHost framework pack. Source-build installs an SDK in a custom location outside this
198+
However, the VMR needs this to not happen while building projects that rely on the
199+
AppHost framework pack. The VMR installs an SDK in a custom location outside this
200200
repository, and setting NetCoreTargetingPackRoot to a different location causes source-build
201201
to restore the AppHost pack as a prebuilt rather than using the one that's present in the SDK.
202-
Source-build doesn't run tests, so the property is simply conditioned out.
202+
The dotnet product build doesn't run tests, so the property is simply conditioned out.
203203
-->
204204
<NetCoreTargetingPackRoot Condition="'$(DotNetBuild)' != 'true'">$(LocalDotNetRoot)packs\</NetCoreTargetingPackRoot>
205-
<!-- This is not correct and needs attention eventually. This is primarily used to find the nethost headers in the apphost pack.
206-
These should be coming from a restored apphost pack, rather than a hard-coded local SDK. In fact, aspnetcore
207-
should not rely on a local SDK or mutating one to build. -->
208-
<NetCoreTargetingPackRoot Condition="'$(DotNetBuild)' == 'true'">$(DotNetRoot)packs\</NetCoreTargetingPackRoot>
209-
210205
</PropertyGroup>
211206

212207
<Import Project="eng\tools\RepoTasks\RepoTasks.tasks" Condition="'$(MSBuildProjectName)' != 'RepoTasks' AND '$(DesignTimeBuild)' != 'true'" />

0 commit comments

Comments
 (0)