Skip to content

Commit f2ab685

Browse files
authored
Reduce duplication in Build.props file (#27619)
- add obvious exclusions and Razor test asset projects to `@(ProjectToExclude)` - remove duplicate exclusions later in Build.props nits: - separate project exclusions for which "meant to be executed by tests" is wrong
1 parent 8d6211f commit f2ab685

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

eng/Build.props

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,17 @@
2121
$(RepoRoot)src\Tools\dotnet-watch\test\TestProjects\**\*.csproj;
2222
$(RepoRoot)src\Tools\Tests.Common\TestProjects\**\*.csproj;
2323
$(RepoRoot)src\Razor\Razor.Design\test\testassets\**\*.*proj;
24+
$(RepoRoot)src\Razor\test\testassets\**\*.*proj;
25+
$(RepoRoot)src\Components\Web.JS\node_modules\**\*.*proj;
26+
$(RepoRoot)src\Components\WebAssembly\Sdk\testassets\**\*.csproj;
27+
" />
28+
29+
<!-- These projects are not meant to be built in this repo. In the Installers case, must explicitly opt in. -->
30+
<ProjectToExclude Include="
2431
$(RepoRoot)src\submodules\**\*.*proj;
2532
$(RepoRoot)src\Installers\**\*.*proj;
2633
$(RepoRoot)src\SignalR\clients\ts\**\node_modules\**\*.*proj;
27-
$(RepoRoot)src\Components\Web.JS\node_modules\**\*.*proj;
28-
$(RepoRoot)src\Components\WebAssembly\Sdk\testassets\**\*.csproj;
29-
$(RepoRoot)src\ProjectTemplates\Web.ProjectTemplates\content\**\*.csproj;
30-
$(RepoRoot)src\ProjectTemplates\Web.ProjectTemplates\content\**\*.fsproj;
34+
$(RepoRoot)src\ProjectTemplates\Web.ProjectTemplates\content\**\*.*proj;
3135
$(RepoRoot)src\ProjectTemplates\Web.Spa.ProjectTemplates\content\**\*.csproj;
3236
" />
3337

@@ -176,8 +180,6 @@
176180
Exclude="
177181
@(ProjectToBuild);
178182
@(ProjectToExclude);
179-
$(RepoRoot)src\Razor\test\testassets\**\*.*proj;
180-
$(RepoRoot)src\Components\WebAssembly\Sdk\testassets\**\*.*proj;
181183
$(RepoRoot)**\node_modules\**\*;
182184
$(RepoRoot)**\bin\**\*;
183185
$(RepoRoot)**\obj\**\*;"
@@ -214,7 +216,6 @@
214216
Exclude="
215217
@(ProjectToBuild);
216218
@(ProjectToExclude);
217-
$(RepoRoot)src\Razor\test\testassets\**\*.*proj;
218219
$(RepoRoot)**\node_modules\**\*;
219220
$(RepoRoot)**\bin\**\*;
220221
$(RepoRoot)**\obj\**\*;"

0 commit comments

Comments
 (0)