Skip to content

Commit f5f770c

Browse files
authored
Delete unnecessary settings
1 parent 245e974 commit f5f770c

File tree

1 file changed

+0
-53
lines changed

1 file changed

+0
-53
lines changed

eng/DotNetBuild.props

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,6 @@
77
<SourceBuildManagedOnly>true</SourceBuildManagedOnly>
88
</PropertyGroup>
99

10-
<!--
11-
Remove inner source .globalconfig file as both the inner and outer config files get loaded and cause a conflict.
12-
Leaving the inner will cause all conflicting settings to be ignored.
13-
https://learn.microsoft.com/dotnet/fundamentals/code-analysis/configuration-files#general-options.
14-
This only needs to be done if there is an inner clone.
15-
-->
16-
<Target Name="RemoveInnerGlobalConfig"
17-
DependsOnTargets="PrepareInnerSourceBuildRepoRoot"
18-
BeforeTargets="RunInnerSourceBuildCommand"
19-
Condition="'$(DotNetBuildOrchestrator)' != 'true'">
20-
21-
<Delete Files="$(InnerSourceBuildRepoRoot).globalconfig" />
22-
</Target>
23-
2410
<!-- Build RepoTasks - this is normally triggered via the build script but the inner ArPow source-build is run via msbuild.
2511
https://github.com/dotnet/source-build/issues/3807 -->
2612
<Target Name="BuildRepoTasks"
@@ -75,43 +61,4 @@
7561
</ItemGroup>
7662
</Target>
7763

78-
<Target Name="RestoreNpmPackages"
79-
Condition="'$(BuildNodeJS)' == 'true' and '$(DotNetBuildSourceOnly)' == 'true'"
80-
BeforeTargets="RunInnerSourceBuildCommand">
81-
82-
<Message Text="Checking node version..." Importance="high" />
83-
<Exec
84-
Command="node --version"
85-
WorkingDirectory="$(InnerSourceBuildRepoRoot)" />
86-
87-
<Message Text="Checking npm version..." Importance="high" />
88-
<Exec
89-
Command="npm --version"
90-
WorkingDirectory="$(InnerSourceBuildRepoRoot)" />
91-
92-
<PropertyGroup>
93-
<!-- Disable installing puppeteer browsers when running in source build -->
94-
<_AdditionalEnvironmentVariable Condition="$(DotNetBuildSourceOnly) == 'true'">PUPPETEER_SKIP_DOWNLOAD=1</_AdditionalEnvironmentVariable>
95-
</PropertyGroup>
96-
97-
<Exec
98-
Command="npm ci"
99-
WorkingDirectory="$(InnerSourceBuildRepoRoot)"
100-
EnvironmentVariables="$(_AdditionalEnvironmentVariable)" />
101-
102-
</Target>
103-
104-
<Target Name="BuildNpmFiles"
105-
Condition="'$(BuildNodeJS)' == 'true' and '$(DotNetBuildSourceOnly)' == 'true'"
106-
DependsOnTargets="RestoreNpmPackages"
107-
BeforeTargets="RunInnerSourceBuildCommand">
108-
109-
<Message Text="Building Node JS files..." Importance="high" />
110-
111-
<Exec
112-
Command="npm run build"
113-
WorkingDirectory="$(InnerSourceBuildRepoRoot)" />
114-
115-
</Target>
116-
11764
</Project>

0 commit comments

Comments
 (0)