- rename RouteChange->Navigate

- don't propagate HTTP/SignalR links to event traces

Author: pavelsavara

src/Components/Components/src/ComponentsActivitySource.cs

@@ -12,7 +12,7 @@ namespace Microsoft.AspNetCore.Components;
 internal class ComponentsActivitySource
 {
     internal const string Name = "Microsoft.AspNetCore.Components";
-    internal const string OnRouteName = $"{Name}.RouteChange";
+    internal const string OnRouteName = $"{Name}.Navigate";
     internal const string OnEventName = $"{Name}.HandleEvent";
 
     private static ActivitySource ActivitySource { get; } = new ActivitySource(Name);

src/Components/Server/src/Circuits/CircuitActivitySource.cs

@@ -9,7 +9,7 @@ namespace Microsoft.AspNetCore.Components.Server.Circuits;
 internal class CircuitActivitySource
 {
     internal const string Name = "Microsoft.AspNetCore.Components.Server.Circuits";
-    internal const string OnCircuitName = $"{Name}.CircuitStart";
+    internal const string OnCircuitName = $"{Name}.StartCircuit";
 
     private ComponentsActivityLinkStore? _activityLinkStore;
 
@@ -42,20 +42,22 @@ public CircuitActivityHandle StartCircuitActivity(string circuitId, ActivityCont
                 }
                 if (httpActivityContext != default)
                 {
-                    // store the http link
-                    _activityLinkStore.SetActivityContext(ComponentsActivityLinkStore.Http, httpActivityContext, null);
+                    // add the http link
+                    activity.AddLink(new ActivityLink(httpActivityContext));
                 }
                 if (signalRActivity != null && signalRActivity.Source.Name == "Microsoft.AspNetCore.SignalR.Server")
                 {
-                    // store the SignalR link
-                    _activityLinkStore.SetActivityContext(ComponentsActivityLinkStore.SignalR, signalRActivity.Context, null);
+                    // add the SignalR link
+                    activity.AddLink(new ActivityLink(signalRActivity.Context));
                 }
             }
             return new CircuitActivityHandle { Previous = signalRActivity, Activity = activity };
         }
         return default;
     }
 
+    // We call this at the end of circuit creation, rather than at the end of the circuit lifecycle
+    // because long-lived traces are difficult to work with in the telemetry UIs
     public void StopCircuitActivity(CircuitActivityHandle activityHandle, Exception? ex)
     {
         var activity = activityHandle.Activity;

src/Components/Server/test/Circuits/CircuitActivitySourceTest.cs

@@ -54,12 +54,11 @@ public void StartCircuitActivity_CreatesAndStartsActivity()
         Assert.Equal(ActivityKind.Internal, activity.Kind);
         Assert.True(activity.IsAllDataRequested);
         Assert.Equal(circuitId, activity.GetTagItem("aspnetcore.components.circuit.id"));
-        Assert.Empty(activity.Links);
+        Assert.Contains(activity.Links, link => link.Context == httpContext);
         Assert.False(activity.IsStopped);
 
         circuitActivitySource.StopCircuitActivity(activityHandle, null);
         Assert.True(activity.IsStopped);
-        Assert.Contains(activity.Links, link => link.Context == httpContext);
     }
 
     [Fact]