Skip to content

Commit f9601f1

Browse files
committed
Not all tests can use session storage.
1 parent e9bf1bf commit f9601f1

File tree

7 files changed

+14
-11
lines changed

7 files changed

+14
-11
lines changed

src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public EnhancedNavigationTest(
3131
// One of the tests here makes use of the streaming rendering page, which uses global state
3232
// so we can't run at the same time as other such tests
3333
public override Task InitializeAsync()
34-
=> InitializeAsync(BrowserFixture.StreamingContext);
34+
=> InitializeAsync(BrowserFixture.StreamingContext, supportEnhancedNavigationSuppression: true);
3535

3636
[Fact]
3737
public void CanNavigateToAnotherPageWhilePreservingCommonDOMElements()

src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public override Task InitializeAsync()
3232
_tempDirectory = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString("N"));
3333
Directory.CreateDirectory(_tempDirectory);
3434

35-
return InitializeAsync(BrowserFixture.StreamingContext);
35+
return InitializeAsync(BrowserFixture.StreamingContext, supportEnhancedNavigationSuppression: true);
3636
}
3737

3838
[Theory]

src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public NoInteractivityTest(
2525
}
2626

2727
public override Task InitializeAsync()
28-
=> InitializeAsync(BrowserFixture.StreamingContext);
28+
=> InitializeAsync(BrowserFixture.StreamingContext, supportEnhancedNavigationSuppression: true);
2929

3030
[Fact]
3131
public void NavigationManagerCanRefreshSSRPageWhenInteractivityNotPresent()

src/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public RedirectionTest(
2525

2626
public override async Task InitializeAsync()
2727
{
28-
await base.InitializeAsync();
28+
await base.InitializeAsync(supportEnhancedNavigationSuppression: true);
2929
Navigate($"{ServerPathBase}/redirect");
3030

3131
_originalH1Element = Browser.Exists(By.TagName("h1"));
@@ -179,7 +179,7 @@ public void RedirectStreamingEnhancedGetToExternal(bool disableThrowNavigationEx
179179
Browser.Exists(By.LinkText("Streaming enhanced GET with external redirection")).Click();
180180
Browser.Contains("microsoft.com", () => Browser.Url);
181181
}
182-
182+
183183

184184
[Theory]
185185
[InlineData(true)]

src/Components/test/E2ETest/ServerRenderingTests/StreamingRenderingTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public StreamingRenderingTest(
2727
}
2828

2929
public override Task InitializeAsync()
30-
=> InitializeAsync(BrowserFixture.StreamingContext);
30+
=> InitializeAsync(BrowserFixture.StreamingContext, supportEnhancedNavigationSuppression: true);
3131

3232
[Fact]
3333
public async Task CanRenderNonstreamingPageWithoutInjectingStreamingMarkersOrHeaders()

src/Components/test/E2ETest/Tests/StatePersistenceTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public StatePersistenceTest(
2929

3030
// Separate contexts to ensure that caches and other state don't interfere across tests.
3131
public override Task InitializeAsync()
32-
=> InitializeAsync(BrowserFixture.StreamingContext + _nextStreamingIdContext++);
32+
=> InitializeAsync(BrowserFixture.StreamingContext + _nextStreamingIdContext++, supportEnhancedNavigationSuppression: true);
3333

3434
// Validates that we can use persisted state across server, webassembly, and auto modes, with and without
3535
// streaming rendering.

src/Shared/E2ETesting/BrowserTestBase.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,19 @@ public Task DisposeAsync()
5454
return Task.CompletedTask;
5555
}
5656

57-
public virtual Task InitializeAsync()
57+
public virtual Task InitializeAsync(bool supportEnhancedNavigationSuppression = false)
5858
{
59-
return InitializeAsync("");
59+
return InitializeAsync("", supportEnhancedNavigationSuppression);
6060
}
6161

62-
public virtual Task InitializeAsync(string isolationContext)
62+
public virtual Task InitializeAsync(string isolationContext, bool supportEnhancedNavigationSuppression = false)
6363
{
6464
InitializeBrowser(isolationContext);
6565
InitializeAsyncCore();
66-
GrantTestId();
66+
if (supportEnhancedNavigationSuppression)
67+
{
68+
GrantTestId();
69+
}
6770
return Task.CompletedTask;
6871
}
6972

0 commit comments

Comments
 (0)