Increase timeout for msbuild processes and added better logging

ajaybhargavb · ajaybhargavb · commit fd4572874e41 · 2018-11-05T18:14:45.000-08:00
diff --git a/test/Microsoft.AspNetCore.Razor.Design.Test/IntegrationTests/MSBuildProcessManager.cs b/test/Microsoft.AspNetCore.Razor.Design.Test/IntegrationTests/MSBuildProcessManager.cs
@@ -17,7 +17,7 @@ public static Task<MSBuildResult> RunProcessAsync(
             TimeSpan? timeout = null,
             MSBuildProcessKind msBuildProcessKind = MSBuildProcessKind.Dotnet)
         {
-            timeout = timeout ?? TimeSpan.FromSeconds(60);
+            timeout = timeout ?? TimeSpan.FromSeconds(120);
 
             var processStartInfo = new ProcessStartInfo()
             {
@@ -76,7 +76,7 @@ public static Task<MSBuildResult> RunProcessAsync(
 
                 // This is a timeout.
                 process.Kill();
-                throw new TimeoutException($"command '${process.StartInfo.FileName} {process.StartInfo.Arguments}' timed out after {timeout}.");
+                throw new TimeoutException($"command '${process.StartInfo.FileName} {process.StartInfo.Arguments}' timed out after {timeout}. Output: {output.ToString()}");
             });
 
             var waitTask = Task.Run(() =>

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public static Task<MSBuildResult> RunProcessAsync(`
`17`	`17`	`TimeSpan? timeout = null,`
`18`	`18`	`MSBuildProcessKind msBuildProcessKind = MSBuildProcessKind.Dotnet)`
`19`	`19`	`{`
`20`		`- timeout = timeout ?? TimeSpan.FromSeconds(60);`
	`20`	`+ timeout = timeout ?? TimeSpan.FromSeconds(120);`
`21`	`21`
`22`	`22`	`var processStartInfo = new ProcessStartInfo()`
`23`	`23`	`{`
`@@ -76,7 +76,7 @@ public static Task<MSBuildResult> RunProcessAsync(`
`76`	`76`
`77`	`77`	`// This is a timeout.`
`78`	`78`	`process.Kill();`
`79`		`- throw new TimeoutException($"command '${process.StartInfo.FileName} {process.StartInfo.Arguments}' timed out after {timeout}.");`
	`79`	`+ throw new TimeoutException($"command '${process.StartInfo.FileName} {process.StartInfo.Arguments}' timed out after {timeout}. Output: {output.ToString()}");`
`80`	`80`	`});`
`81`	`81`
`82`	`82`	`var waitTask = Task.Run(() =>`