Skip to content

Commit fed0e5a

Browse files
committed
Clean up global interactivity tests.
1 parent 1caeaa6 commit fed0e5a

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

src/Components/test/E2ETest/Tests/GlobalInteractivityTest.cs

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void CanRenderNotFoundInteractive(string renderingMode, bool useCustomNot
3737

3838
if (useCustomNotFoundPage)
3939
{
40-
AssertCustomNotFoundPageRendered();
40+
AssertNotFoundPageRendered();
4141
}
4242
else
4343
{
@@ -144,7 +144,7 @@ public void CanRenderNotFoundPage_SSR(bool streamingStarted)
144144
{
145145
string streamingPath = streamingStarted ? "-streaming" : "";
146146
Navigate($"{ServerPathBase}/set-not-found-ssr{streamingPath}?useCustomNotFoundPage=true");
147-
AssertCustomNotFoundPageRendered();
147+
AssertNotFoundPageRendered();
148148
}
149149

150150
[Theory]
@@ -153,26 +153,31 @@ public void CanRenderNotFoundPage_SSR(bool streamingStarted)
153153
public void CanRenderNotFoundPage_Interactive(string renderMode)
154154
{
155155
Navigate($"{ServerPathBase}/set-not-found?useCustomNotFoundPage=true&renderMode={renderMode}");
156-
AssertCustomNotFoundPageRendered();
156+
AssertNotFoundPageRendered();
157157
}
158158

159-
private void AssertCustomNotFoundPageRendered()
159+
private void AssertNotFoundPageRendered()
160160
{
161-
var infoText = Browser.FindElement(By.Id("test-info")).Text;
162-
Assert.Contains("Welcome On Custom Not Found Page", infoText);
161+
Browser.Equal("Welcome On Custom Not Found Page", () => Browser.FindElement(By.Id("test-info")).Text);
163162
// custom page should have a custom layout
164-
var aboutLink = Browser.FindElement(By.Id("about-link")).Text;
165-
Assert.Contains("About", aboutLink);
163+
Browser.Equal("About", () => Browser.FindElement(By.Id("about-link")).Text);
166164
}
167165

168166
[Theory]
169167
[InlineData(false)]
170168
[InlineData(true)]
171-
public void DoesNotReExecuteIf404WasHandled_SSR(bool streamingStarted)
169+
public void CanRenderNotFoundIfNotFoundPageTypeNotProvided_SSR(bool streamingStarted)
172170
{
173171
string streamingPath = streamingStarted ? "-streaming" : "";
174172
Navigate($"{ServerPathBase}/reexecution/set-not-found-ssr{streamingPath}");
175-
AssertNotFoundFragmentRendered();
173+
if (streamingStarted)
174+
{
175+
AssertReExecutedPageRendered();
176+
}
177+
else
178+
{
179+
AssertNotFoundFragmentRendered();
180+
}
176181
}
177182

178183
[Theory]
@@ -184,19 +189,15 @@ public void DoesNotReExecuteIf404WasHandled_Interactive(string renderMode)
184189
AssertNotFoundFragmentRendered();
185190
}
186191

187-
private void AssertNotFoundFragmentRendered()
188-
{
189-
var body = Browser.FindElement(By.TagName("body"));
190-
var notFound = Browser.FindElement(By.Id("not-found-fragment")).Text;
192+
private void AssertNotFoundFragmentRendered() =>
191193
Browser.Equal("There's nothing here", () => Browser.FindElement(By.Id("not-found-fragment")).Text);
192-
}
193194

194195
[Fact]
195196
public void StatusCodePagesWithReExecution()
196197
{
197198
Navigate($"{ServerPathBase}/reexecution/trigger-404");
198-
Assert404ReExecuted();
199+
AssertReExecutedPageRendered();
199200
}
200-
private void Assert404ReExecuted() =>
201+
private void AssertReExecutedPageRendered() =>
201202
Browser.Equal("Welcome On Page Re-executed After Not Found Event", () => Browser.Exists(By.Id("test-info")).Text);
202203
}

0 commit comments

Comments
 (0)