Rename AuthenticationHandler constructor argument ILoggerFactory to loggerFactory

[Meir017]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The current constructor has a ILoggerFactory as an argument named logger, this is misleading.

https://github.com/dotnet/aspnetcore/blob/4d23e511baea8af1e2813b95d41abdb61111393e/src/Security/Authentication/Core/src/AuthenticationHandler.cs#L133C5-L133C114

Describe the solution you'd like

-     protected AuthenticationHandler(IOptionsMonitor<TOptions> options, ILoggerFactory logger, UrlEncoder encoder)
+     protected AuthenticationHandler(IOptionsMonitor<TOptions> options, ILoggerFactory loggerFactory, UrlEncoder encoder)

Additional context

No response

[MackinnonBuck]

Thanks for reaching out, @Meir017.

While this is a good suggestion, we wouldn't make this change at this point in time since this API has already shipped and renaming a parameter is a breaking change.

[Meir017]

At least we'll have this issue for future reference if anyone asks about this again 😀