Use TimeProvider instead of DateTimeOffset in UserManager

[bpiccand]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

I am trying to implement integration tests in my application that uses the Identity package. I want to test that the user lockout feature is correctly configured in my application and am using the TimeProvider and FakeTimeProvider which where introduced with .NET 8 to ensure the user is not locked anymore after the desired amount of time.

Unfortunately, the UserManager class still uses the static DateTimeOffset instead of the new TimeProvider and therefore does not react to time changes in my tests.

Describe the solution you'd like

Replace the DateTimeOffset class with the TimeProvider to determine the current time in the Identity package

Additional context

No response

[martincostello]

Looks like the two relevant places are here:

aspnetcore/src/Identity/Extensions.Core/src/UserManager.cs

Line 2070 in 1efded6

return lockoutTime >= DateTimeOffset.UtcNow;

aspnetcore/src/Identity/Extensions.Core/src/UserManager.cs

Lines 2189 to 2190 in 1efded6

	await store.SetLockoutEndDateAsync(user, DateTimeOffset.UtcNow.Add(Options.Lockout.DefaultLockoutTimeSpan),
	CancellationToken).ConfigureAwait(false);

Feels like this could be relatively trivially fixed without needing to change the constructor (and thus needing an API change to be approved) by adding a new method like this:

private DateTimeOffset UtcNow()
{
    var timeProvider = ServiceProvider.GetService<TimeProvider>();
    return timeProvider?.GetUtcNow() ?? DateTimeOffset.UtcNow;
}

Then changing the two usages to:

- await store.SetLockoutEndDateAsync(user, DateTimeOffset.UtcNow.Add(Options.Lockout.DefaultLockoutTimeSpan),
+ await store.SetLockoutEndDateAsync(user, UtcNow().Add(Options.Lockout.DefaultLockoutTimeSpan),

- return lockoutTime >= DateTimeOffset.UtcNow;
+ return lockoutTime >= UtcNow();

Would you like to submit a PR to fix it for .NET 10?

[bpiccand]

Yes, will do

[dotnet-policy-service]

Looks like this issue has been identified as a candidate for community contribution. If you're considering sending a PR for this issue, look for the Summary Comment link in the issue description. That comment has been left by an engineer on our team to help you get started with handling this issue. You can learn more about our Help Wanted process here