OpenAPI: Delta<> From OData days generates really weird.

[niemyjski]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Delta<> From OData days generates really weird. I don't have it included here but it generates a schema for each T in.. OData (e.g., DeltaOfUpdateUser) See (https://github.com/exceptionless/Exceptionless/blob/feature/net-10-upgrade-with-open-api-changes/src/Exceptionless.Web/Controllers/UserController.cs#L120)

Expected Behavior

These should just work out of the box.

Steps To Reproduce

Clone https://github.com/exceptionless/aspnet-core-net10-issues# and run it, hit the open api json endpoint.

Exceptions (if any)

No response

.NET Version

10 preview 6

Anything else?

MacOS Latest, Rider/VS Code

#62150

[martincostello]

Delta<T> doesn't look like a simple model type, but a "framework-y" type with lots of custom behaviours and surface area. Particularly given that it derives from DynamicObject.

I doubt that would ever work out-of-the-box, especially as it's not part of .NET/ASP.NET Core - it likely needs a custom JSON converter to be used for OpenAPI documentation or a custom transformer.

[captainsafia]

I doubt that would ever work out-of-the-box, especially as it's not part of .NET/ASP.NET Core - it likely needs a custom JSON converter to be used for OpenAPI documentation or a custom transformer.

Yes, support for OData-based typed will require custom converters or transformers and is not handled in the built-in implementation at the time.

[niemyjski]

Delta should be treated as Optional (in typescript). Yes it allows extra, but at least ensure the T is there.

[dotnet-policy-service]

This issue has been resolved and has not had any activity for 1 day. It will be closed for housekeeping purposes.

See our Issue Management Policies for more information.

[niemyjski]

Further it's a Union of dynamic and type of T. I think you would at least treat it as two different types instead of one. (Maybe the same goes for any generic?)

[martincostello]

Something like that would likely have to wait until C# supports discriminated unions.