Skip to content

Conversation

BrennanConroy
Copy link
Member

Updates how argument binding errors are reported to include which argument caused the binding failure, making it easier to diagnose issues when types do not match.

Finally able to get rid of a sticky note I've had on my desk for >3 years.

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 20:51
@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Oct 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances SignalR's error reporting by adding parameter index information to invocation binding exception messages. When argument binding fails due to type mismatches, the error message now includes which specific argument caused the failure (e.g., "Error binding argument 1" instead of "Error binding arguments").

  • Updates error message format across all SignalR protocol implementations to include argument index
  • Modifies loop structures to track the current argument index for error reporting
  • Updates corresponding test expectations to match the new error message format

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
MessagePackHubProtocolTestBase.cs Updates test expectations for MessagePack protocol error messages to include argument index
JsonHubProtocolTestsBase.cs Updates test expectations for JSON protocol error messages to include argument index
NewtonsoftJsonHubProtocol.cs Modifies error handling to include parameter index in binding failure messages
MessagePackHubProtocolWorker.cs Updates loop structure and error message to track and report argument index
JsonHubProtocol.cs Adds parameter index to binding error messages
GsonHubProtocolTest.java Updates Java client test expectations for new error message format
GsonHubProtocol.java Implements argument index tracking in Java client protocol implementation
HubConnectionTests.cs Updates functional test expectations for new error message format

@BrennanConroy
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants