Update branding to 2.3.7 & merge internal commits #64089
Merged
+260
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### AI description (iteration 1) #### PR Classification Bug fix to ensure correct parsing of HTTP chunked requests. #### PR Summary This pull request refines chunked request parsing by enforcing stricter checks on chunk extensions in accordance with RFC 9112, and it adds thorough tests for both valid and invalid input scenarios. The changes improve error handling and request rejection when encountering malformed chunk extensions. - **`src/Servers/Kestrel/test/FunctionalTests/ChunkedRequestTests.cs`**: Added tests to validate behavior for requests with invalid newlines and various chunk extension formats. - **`src/Servers/Kestrel/Core/src/Internal/Http/Http1MessageBody.cs`**: Updated parsing logic to correctly detect CRLF sequences and reject improperly formatted chunk extensions, including support for an insecure parsing switch. - **`src/Servers/Kestrel/Core/test/MessageBodyTests.cs`**: Modified test inputs to align with the updated chunk extension parsing. - **`src/Servers/Kestrel/Core/src/Internal/Http/RequestRejectionReason.cs`**: Introduced a new rejection reason, `BadChunkExtension`, for invalid chunk extensions. - **`eng/PatchConfig.props`**: Updated patch configuration for version 2.3.4 to include the Kestrel core package changes. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
wtgodbe
requested review from
a team,
BrennanConroy,
Tratcher and
halter73
as code owners
There was a problem hiding this comment.
Pull Request Overview
Updates branding to version 2.3.7 and incorporates internal commits introducing stricter chunked request parsing, a new rejection reason, and associated tests.
- Adds parsing logic for chunk extensions with secure vs legacy (insecure) modes and introduces BadChunkExtension rejection.
- Updates baseline and patch configuration versions for Kestrel.Core.
- Adds functional and unit tests covering valid/invalid chunk extensions and newline edge cases.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.props | Bumps patch version to 2.3.7. |
| src/Servers/Kestrel/test/FunctionalTests/ChunkedRequestTests.cs | Adds tests for valid and invalid chunk extensions and newline edge cases. |
| src/Servers/Kestrel/Core/test/MessageBodyTests.cs | Adjusts test inputs to align with new chunk extension parsing behavior. |
| src/Servers/Kestrel/Core/src/Internal/Http/RequestRejectionReason.cs | Adds BadChunkExtension enum value and trailing comma. |
| src/Servers/Kestrel/Core/src/Internal/Http/PipelineExtensions.cs | Introduces PositionOfAny helper for ReadOnlySequence search. |
| src/Servers/Kestrel/Core/src/Internal/Http/Http1MessageBody.cs | Implements chunk extension parsing with secure/insecure modes and rejection logic. |
| src/Servers/Kestrel/Core/src/CoreStrings.resx | Adds error string for bad chunk extension. |
| src/Servers/Kestrel/Core/src/BadHttpRequestException.cs | Maps new rejection reason to 400 Bad Request exception. |
| eng/PatchConfig.props | Adds 2.3.6 packages-to-patch configuration and initializes 2.3.7 group. |
| eng/Baseline.xml | Updates baseline version and Kestrel.Core package baseline. |
| eng/Baseline.Designer.props | Updates baseline package version for Kestrel.Core. |
Files not reviewed (1)
- src/Servers/Kestrel/Core/src/Properties/CoreStrings.Designer.cs: Language not supported
|
Hi @@wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
BrennanConroy
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.