[release/8.0] [Blazor] Fix @key not being respected for interactive WebAssembly components after publish
#53748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
added
Servicing-consider
|
Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
ghost
added this to the
|
Hi @MackinnonBuck. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
mkArtakMSFT
approved these changes
Feb 1, 2024
Contributor
mkArtakMSFT
left a comment
mkArtakMSFT
left a comment
There was a problem hiding this comment.
Thanks @MackinnonBuck !
rbhanda
added
Servicing-approved
|
Hi @MackinnonBuck. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
dotnet-policy-service
bot
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
@keynot being respected for interactive WebAssembly components after publishBackport of #53746
Fixes an issue where, after publishing a Blazor Web App, components with the
InteractiveWebAssemblyrender mode could not receive parameter updates from SSR updates. If the component received any changed parameters, it would always get destroyed and re-initialized regardless of whether a matching@keywas present.Description
The problem was that members of
ComponentMarkerKeywere getting trimmed away after publish. The fix adds new trimming attributes to preserve the members ofComponentMarkerKey.Fixes #53289
Customer Impact
Without this fix, customers will not be able to preserve component instances between enhanced page updates if any component parameters change. This includes enhanced navigations (navigating from one internal page to another), and enhanced form posts. Because this is a problem specific to publishing, customers may not realize this bug exists in their app until it's deployed.
Regression?
This bug is specific to apps utilizing static server rendering, which is a new feature in .NET 8.
Risk
The fix is trivial and very unlikely to negatively impact other functionality.
Verification
Packaging changes reviewed?