Skip to content

Conversation

@vseanreesermsft
Copy link
Contributor

No description provided.

SteveSandersonMS and others added 14 commits July 2, 2024 18:08
# Limit MaxItemCount in Virtualize

Limits how much data Virtualize will load by default.

## Description

Ensures that `<Virtualize>` won't unexpectedly load or render a huge amount of data. Previously, a badly-behaved client could force it to load `int.MaxValue / ItemSize` items (if the underlying data store has that much data in it), where `ItemSize` is typically around 50.

Fixes MSRC case 88893

## Customer Impact

Addresses a reported issue whereby a badly-behaved client may report an arbitrarily-large viewport size, causing the server-side `Virtualize` component to perform a correspondingly large data load, and then to hold rendertree data in memory corresponding to this many items.

## Regression?

- [ ] Yes
- [x] No

[If yes, specify the version the behavior has regressed from]

## Risk

- [ ] High
- [ ] Medium
- [x] Low

By default the max items is set to 1000, which is way more than would normally be visible on any realistic screen. Typical per-item size is at least 20px, so unless someone's screen is > 20,000 pixels tall, they wouldn't exceed this new default maximum.

The logic is structured so that, if the client's viewport does not exceed this maximum, then no behavioral change should occur.

## Verification

- [x] Manual (required)
- [x] Automated

## Packaging changes reviewed?

- [ ] Yes
- [ ] No
- [x] N/A
…otnet-runtime build 20240716.10

Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport
 From Version 6.0.32-servicing.24314.7 -> To Version 6.0.33-servicing.24366.10
…ng/internal/dotnet-runtime

This pull request updates the following dependencies

[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20240716.10
- **Date Produced**: July 16, 2024 9:27:15 PM UTC
- **Commit**: 6c636980f730a30c3f5352cff80ce035ae53f016
- **Branch**: refs/heads/internal/release/6.0

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.32-servicing.24314.7 to 6.0.33-servicing.24366.10][1]
  - **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.NETCore.App.Ref**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.32-servicing.24314.7 to 6.0.33-servicing.24366.10][1]

[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GCe77011b31a3e5c47d931248a64b47f9b2d47853d&targetVersion=GC6c636980f730a30c3f5352cff80ce035ae53f016&_a=files

[DependencyUpdate]: <> (End)

[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
#### AI description  (iteration 1)
#### PR Classification
Bug fix to address an issue with SAS token generation.

#### PR Summary
This pull request updates the `get-delegation-sas.yml` script to handle a specific issue with SAS tokens containing slashes, which cause incorrect downloads of correlation payloads.
- `get-delegation-sas.yml`: Added a loop to regenerate the SAS token if it contains a slash, ensuring valid token generation.
…ng/internal/dotnet-efcore

This pull request updates the following dependencies

[marker]: <> (Begin:1ac68a20-28fc-4e11-3a4d-08d961c5a689)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-efcore
- **Subscription**: 1ac68a20-28fc-4e11-3a4d-08d961c5a689
- **Build**: 20240711.5
- **Date Produced**: July 11, 2024 8:05:29 PM UTC
- **Commit**: 73adbdc34d00e8fc71cb835171ee5ba73cc9e53f
- **Branch**: refs/heads/internal/release/6.0

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **dotnet-ef**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore.Design**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore.InMemory**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore.Relational**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore.Sqlite**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore.SqlServer**: [from 6.0.32 to 6.0.33][1]
  - **Microsoft.EntityFrameworkCore.Tools**: [from 6.0.32 to 6.0.33][1]

[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-efcore/branches?baseVersion=GCd938643248c7390b295b44237eb64520ac69fd53&targetVersion=GC73adbdc34d00e8fc71cb835171ee5ba73cc9e53f&_a=files

[DependencyUpdate]: <> (End)

[marker]: <> (End:1ac68a20-28fc-4e11-3a4d-08d961c5a689)
…-merge-6.0-2024-08-13-1041-1fc711ba-b916-49fb-9f47-00e26e077d90
@vseanreesermsft vseanreesermsft requested review from a team and wtgodbe as code owners August 13, 2024 17:41
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 13, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 6.0.x milestone Aug 13, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.34 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants