Fix Http3 Pipe complete #58298
Merged
Fix Http3 Pipe complete #58298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't complete the `PipeWriter` when it still might be used by Application code. ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request addresses a bug in the HTTP/3 implementation related to memory management and pipe completion. - `Http3RequestTests.cs`: Added a new test to ensure memory is preserved when the connection closes. - `Http3OutputProducer.cs`: Refactored `Dispose` method and added `Complete` method to properly handle pipe completion. - `DiagnosticMemoryPool.cs`: Added `ContainsMemory` method to check if memory is still rented from the pool. - `Http3Stream.cs`: Ensured `Complete` is called on `_http3Output` when the stream is closed. - `Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj`: Added `InternalsVisibleTo` for `Interop.FunctionalTests`.
wtgodbe
requested review from
BrennanConroy,
JamesNK,
halter73 and
mgravell
as code owners
ghost
added
the
area-networking
BrennanConroy
approved these changes
Oct 8, 2024
captainsafia
pushed a commit
that referenced
this pull request
Dec 31, 2024
Don't complete the `PipeWriter` when it still might be used by Application code. ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request addresses a bug in the HTTP/3 implementation related to memory management and pipe completion. - `Http3RequestTests.cs`: Added a new test to ensure memory is preserved when the connection closes. - `Http3OutputProducer.cs`: Refactored `Dispose` method and added `Complete` method to properly handle pipe completion. - `DiagnosticMemoryPool.cs`: Added `ContainsMemory` method to check if memory is still rented from the pool. - `Http3Stream.cs`: Ensured `Complete` is called on `_http3Output` when the stream is closed. - `Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj`: Added `InternalsVisibleTo` for `Interop.FunctionalTests`. Co-authored-by: Brennan Conroy <[email protected]>
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Don't complete the `PipeWriter` when it still might be used by Application code. ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request addresses a bug in the HTTP/3 implementation related to memory management and pipe completion. - `Http3RequestTests.cs`: Added a new test to ensure memory is preserved when the connection closes. - `Http3OutputProducer.cs`: Refactored `Dispose` method and added `Complete` method to properly handle pipe completion. - `DiagnosticMemoryPool.cs`: Added `ContainsMemory` method to check if memory is still rented from the pool. - `Http3Stream.cs`: Ensured `Complete` is called on `_http3Output` when the stream is closed. - `Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj`: Added `InternalsVisibleTo` for `Interop.FunctionalTests`. Co-authored-by: Brennan Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't complete the
PipeWriterwhen it still might be used by Application code.This pull request addresses a bug in the HTTP/3 implementation related to memory management and pipe completion.