Skip to content

Use FullName in InstallJdk script #58618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Use FullName in InstallJdk script #58618

merged 1 commit into from
Oct 25, 2024

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Oct 24, 2024 •
edited
Loading

#58557 broke InstallJdk.ps1 on my machine, so I'm updating the fix to explicitly use the FullName property from Get-ChildItem.

Error for reference:

(aspnetcore) PS C:\dev\dotnet\aspnetcore> .\eng\scripts\InstallJdk.ps2
Starting download of JDK 11.0.24
GET https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/java/microsoft-jdk-11.0.24-windows-x64.zip
Download of 'https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/java/microsoft-jdk-11.0.24-windows-x64.zip' complete, saved to C:\dev\dotnet\aspnetcore\obj/jdk.zip...
Done downloading JDK 11.0.24
Expanded JDK to C:\dev\dotnet\aspnetcore\obj
Installing JDK to C:\dev\dotnet\aspnetcore\.tools\jdk\win-x64\
Move-Item: C:\dev\dotnet\aspnetcore\eng\scripts\InstallJdk.ps1:49
Line |
  49 |  Move-Item "$tempDir/jdk/$(Get-ChildItem -Path "$tempDir/jdk" | Select …
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'C:\dev\dotnet\aspnetcore\obj\jdk\C:\dev\dotnet\aspnetcore\obj\jdk\jdk-11.0.24+8' because it does not exist.

@halter73 halter73 requested review from a team and wtgodbe as code owners October 24, 2024 23:13
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 24, 2024
@halter73 halter73 enabled auto-merge (squash) October 24, 2024 23:21
@halter73 halter73 merged commit d26729e into main Oct 25, 2024
27 checks passed
@halter73 halter73 deleted the halter73/fullname branch October 25, 2024 22:07
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 25, 2024
@BrennanConroy BrennanConroy mentioned this pull request Nov 26, 2024
Closed
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@halter73 @captainsafia
Use FullName in InstallJdk script (#58618)
a84202b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview1

Development

Successfully merging this pull request may close these issues.

2 participants

@halter73 @BrennanConroy