Fully qualify type names for services when resolving in RequestDelegateGenerator #58640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two places correspond to resolution of a service from DI when
attributed with `FromServicesAttribute` or with
`FromKeyedServicesAttribute`. When the type name of the service is not
fully qualified, the generator can generate code which fails to compile.
For example, given a service `ExampleService` in namespace `Http`, the
generator can generate code to resolve an instance of such a service
like this:
```c#
var e_local = httpContext.RequestServices.GetRequiredKeyedService<Http.ExampleService>("example");
```
…but `Microsoft.AspNetCore.Http` is a nearer match for the reference to
"Http", so the compiler will look for a type
`Microsoft.AspNetCore.Http.ExampleService` (which doesn't exist – at
least, not at time of writing), and compilation will fail.
Fixes: dotnet#58633
chrisoverzero
requested review from
BrennanConroy,
captainsafia and
halter73
as code owners
ghost
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Thanks for opening a PR for this! I left one recommendation inline.
Also -- any chance we can add test coverage for this?
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Emitters/EndpointParameterEmitter.cs
Outdated
Show resolved
Hide resolved
captainsafia
approved these changes
Oct 28, 2024
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Looks good overall! Left one small comment about a possibly unneeded using in the base class for tests.
src/Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTestBase.cs
Show resolved
Hide resolved
captainsafia
changed the title
captainsafia
added
feature-rdg
area-minimal
Contributor
Author
|
The failures here look unrelated. Is there a way to kick the build off again, or is this waiting for something? |
Member
Our builds can be flakey sometimes. I've just kicked it to hopefully get this through. 🤞🏽 |
chrisoverzero
deleted the
feature/fully-qualify-type-names-when-resolving
branch
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
…teGenerator (#58640) * Fully Qualify Type Names When Resolving in RDG These two places correspond to resolution of a service from DI when attributed with `FromServicesAttribute` or with `FromKeyedServicesAttribute`. When the type name of the service is not fully qualified, the generator can generate code which fails to compile. For example, given a service `ExampleService` in namespace `Http`, the generator can generate code to resolve an instance of such a service like this: ```c# var e_local = httpContext.RequestServices.GetRequiredKeyedService<Http.ExampleService>("example"); ``` …but `Microsoft.AspNetCore.Http` is a nearer match for the reference to "Http", so the compiler will look for a type `Microsoft.AspNetCore.Http.ExampleService` (which doesn't exist – at least, not at time of writing), and compilation will fail. Fixes: #58633 * Correct Symbol Display Format and Add Tests See: #58633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully Qualify Type Names When Resolving in RDG
These two places correspond to resolution of a service from DI when attributed with
FromServicesAttributeor withFromKeyedServicesAttribute. When the type name of the service is not fully qualified, the generator can generate code which fails to compile.Description
For example, given a service
ExampleServicein namespaceHttp, the generator can generate code to resolve an instance of such a service like this:…but
Microsoft.AspNetCore.Httpis a nearer match for the reference to "Http", so the compiler will look for a typeMicrosoft.AspNetCore.Http.ExampleService(which doesn't exist – at least, not at time of writing), and compilation will fail.Fixes #58633