Always use --apply-cop-headers in ThreadingAppTest #58642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this wasn't necessary before, but recently a bunch of builds are failing due to timeouts in
ThreadingAppTest. When running the tests locally inmain, I see the following errors in the browser developer console:Given the name of
ThreadingAppTest, I assume the Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy headers are indeed required, but they weren't being sent previously. I saw #54351 which added the ability to run all E2E tests on a multithreaded runtime, but I assume that we don't want to touch assembly metadata for this because mostComponents.TestServer-based tests (which is whatWebAssemblyTestHelperreads the metadata from) don't need it.I first noticed this in a runtime dependency update, but I also saw this locally on main and other unrelated PRs, so I decided to open a new PR for this.
The error appears to surface as a timeout establishing an HTTP connection on the CI, but locally, I get a timeout waiting for the app to transition out of the "Loading..." state. There are some other differences like the local errors I see being consistent while the CI errors are hard to predict. Maybe this is explained by the CI runs occurring on different machines though. So, it's possible this won't fix the CI error, but it still seems worth it to fix the error for local dev.
Local Error:
CI Error:
Ex:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=853162&view=ms.vss-test-web.build-test-results-tab
https://dev.azure.com/dnceng-public/public/_build/results?buildId=852847&view=logs&j=fe94c0c9-bb8c-5d6f-3b51-887173cc2f5c&t=b4bd3469-f776-5941-b623-568498d38bde&s=96ac2280-8cb4-5df5-99de-dd2da759617d
You might have to look at previous builds if they've be rerun.
I plan on labeling #54497 and #58242 as
test-fixedsince these tests both failed for me locally before but now pass. However, the error I'm seeing is more similar to #54497 than #58242. @MackinnonBuck let me know if I should leave the latter open.