Skip to content

Always use --apply-cop-headers in ThreadingAppTest #58642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Always use --apply-cop-headers in ThreadingAppTest #58642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa524a2
Always use --apply-cop-headers in ThreadingAppTest
halter73 Oct 25, 2024
97714a6
Quarantine remaining ThreadingAppTest methods
halter73 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Components/test/E2ETest/Infrastructure/ServerFixtures/BlazorWasmTestAppFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public class BlazorWasmTestAppFixture<TProgram> : WebHostServerFixture
public string PathBase { get; set; }
public string ContentRoot { get; private set; }

public bool RequiresMultithreadingHeaders { get; set; }

protected override IHost CreateWebHost()
{
if (TestTrimmedOrMultithreadingApps)
Expand Down Expand Up @@ -61,7 +63,7 @@ protected override IHost CreateWebHost()
args.Add(Environment);
}

if (WebAssemblyTestHelper.MultithreadingIsEnabled())
if (RequiresMultithreadingHeaders || WebAssemblyTestHelper.MultithreadingIsEnabled())
{
args.Add("--apply-cop-headers");
}
Expand Down
5 changes: 5 additions & 0 deletions src/Components/test/E2ETest/Tests/ThreadingAppTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public ThreadingAppTest(
ITestOutputHelper output)
: base(browserFixture, serverFixture, output)
{
serverFixture.RequiresMultithreadingHeaders = true;
}

protected override void InitializeAsyncCore()
Expand All @@ -28,12 +29,14 @@ protected override void InitializeAsyncCore()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
public void HasTitle()
{
Assert.Equal("Blazor standalone", Browser.Title);
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
public void HasHeading()
{
Assert.Equal("Hello, world!", Browser.Exists(By.TagName("h1")).Text);
Expand Down Expand Up @@ -85,6 +88,7 @@ public void CounterPageCanUseThreads()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
public void HasFetchDataPage()
{
// Navigate to "Fetch data"
Expand All @@ -106,6 +110,7 @@ public void HasFetchDataPage()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54761")]
public void IsStarted()
{
// Read from property
Expand Down
Loading