Use the runtime->AspNetCore transport package as the sentinel package instead of the BrowserDebugHost package #58847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of the BrowserDebugHost package. For the VMR to correctly look up packages based on the non-shipping versions, we need the sentinel package to be built 100% of the time. The BrowserDebugHost is not built on all verticals, but the transport package here is (and ASP.NET Core already consumes it on all verticals).
jkoritzinsky
added
the
area-infrastructure
steveisok
approved these changes
Nov 9, 2024
wtgodbe
approved these changes
Nov 9, 2024
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
… instead of the BrowserDebugHost package (#58847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the VMR to correctly look up packages based on the non-shipping versions, we need the sentinel package to be built 100% of the time. The BrowserDebugHost is not built on all verticals, but the transport package here is (and ASP.NET Core already consumes it on all verticals).
This is required to unblock dotnet/aspnetcore->dotnet/sdk flow.