Skip to content

chore: fixed missed conditional theory for testing named pipe #58849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: fixed missed conditional theory for testing named pipe #58849

merged 1 commit into from
Nov 11, 2024

Conversation

@AliKhalili
Copy link
Contributor

Fixed missed conditional theory for testing named pipe

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

This PR aims to replace the [Theory] attribute with [ConditionalTheory] in NamedPipeConnectionListenerTests, as these tests are Windows-specific and were causing errors on macOS.

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 9, 2024
@JamesNK
Copy link
Member

JamesNK commented Nov 11, 2024

Thanks for the PR!

@JamesNK JamesNK merged commit afb0588 into dotnet:main Nov 11, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 11, 2024
@AliKhalili AliKhalili deleted the skip-test-mac-os branch November 12, 2024 07:38
@danroth27 danroth27 added the task label Feb 11, 2025
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@AliKhalili @captainsafia
chore: fixed missed conditional theory for testing named pipe (#58849)
135f4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@mgravell mgravell Awaiting requested review from mgravell

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member task

Projects

None yet

Milestone

10.0-preview1

Development

Successfully merging this pull request may close these issues.

3 participants

@AliKhalili @JamesNK @danroth27