Skip to content

Conversation

@wokket
Copy link
Contributor

@wokket wokket commented Nov 14, 2024

nit: doc comment typo

  • [ x] You've read the Contributor Guide and Code of Conduct.
  • [ ] You've included unit or integration tests for your change, where applicable.
  • [ x] You've included inline docs for your change, where applicable.
  • [ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Fix typo in doc comments. My first .Net PR, apologies if targeting wrong branch or similar

@ghost ghost added the area-security label Nov 14, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 14, 2024
@martincostello
Copy link
Member

The same typo is here too 😄:

// Examine tokens to figure out wether the current token is the argument name.

@mkArtakMSFT
Copy link
Contributor

Thanks @wokket. Could you please also include the fix to the file @martincostello referred to so that we merge both together.

@mkArtakMSFT mkArtakMSFT self-assigned this Nov 18, 2024
@wokket
Copy link
Contributor Author

wokket commented Nov 18, 2024

@dotnet-policy-service agree

Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wokket!

@mkArtakMSFT mkArtakMSFT merged commit e130357 into dotnet:main Nov 18, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 18, 2024
@wokket wokket deleted the nit/PAR-doc branch November 18, 2024 23:45
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
* nit: doc comment typo

* nit: Typo in code comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-security community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants