ContinueOnError in windows local development job #59037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
BrennanConroy
approved these changes
Nov 18, 2024
MackinnonBuck
approved these changes
Nov 18, 2024
Member
|
Does this need to go through a full CI? It seems safe enough to merge IMO since it unblocks other things. |
Member
Author
I'd like to see the local dev job behave how I expect it to first, I'll merge as soon as that's done |
Member
Author
|
Yup, tests failed but the job was yellow. Force merging. |
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows local development job is extremely flaky right now due to #58957. Continue the job on error until that issue is resolved