Skip to content

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Nov 22, 2024

  • Updates the SDK to validate recent changes.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 22, 2024
@javiercn javiercn marked this pull request as ready for review November 22, 2024 17:34
@javiercn javiercn requested review from a team and wtgodbe as code owners November 22, 2024 17:34
Comment on lines +24 to +26
<_JsBuildOutput>
<RelativePath>%(_JsBuildOutput.RecursiveDir)%(Filename)%(Extension)</RelativePath>
</_JsBuildOutput>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generating a FullPath, which DefineStaticWebAssets below didn't like on the new implementation. I have a separate PR to address this edge case on the SDK, but it's simpler here to provide the relative path.

@javiercn javiercn merged commit 3ba179a into main Nov 22, 2024
27 checks passed
@javiercn javiercn deleted the javiercn/update-dotnet-sdk branch November 22, 2024 17:40
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants