Fix flaky SignalR test: RequestTimeoutDisabledWhenConnected #59819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
pending-ci-rerun
captainsafia
approved these changes
Jan 21, 2025
| await connection.StartAsync(); | ||
|
|
||
| // Easy way to make sure everything is set is to send and receive data over the connection | ||
| await connection.Transport.Output.WriteAsync(new byte[2]); |
Member
There was a problem hiding this comment.
Are two bytes necessary for this or is any number of bytes sufficient?
Member
Author
There was a problem hiding this comment.
Any number, not sure why I put 2 😆
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await connection.StartAsync();only waits for the connection headers to be written, which means there is a race between the connection starting and the test checking if the request timeout feature was disabled. To fix this, I added writing and reading to the connection to make sure everything is fully set up on the connection before testing the feature.