Skip to content

Fix flaky Kestrel Http/2 Stream tests #59820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix flaky Kestrel Http/2 Stream tests #59820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a66703b
Fix flaky Kestrel Http/2 Stream tests
BrennanConroy Jan 10, 2025
d53dcd5
fb
BrennanConroy Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,9 +404,11 @@ public async Task StreamPool_SingleStream_ReturnedToPool()
{
// Add stream to Http2Connection._completedStreams inline with SetResult().
var serverTcs = new TaskCompletionSource();
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await InitializeConnectionAsync(async context =>
{
appTcs.TrySetResult();
await serverTcs.Task;
await _echoApplication(context);
});
Expand All @@ -415,6 +417,8 @@ await InitializeConnectionAsync(async context =>

await StartStreamAsync(1, _browserRequestHeaders, endStream: true);

// If app code is running we know the stream has been created
await appTcs.Task;
var stream = _connection._streams[1];
serverTcs.SetResult();

Expand Down Expand Up @@ -490,9 +494,12 @@ public async Task StreamPool_MultipleStreamsInSequence_PooledStreamReused()
TaskCompletionSource appDelegateTcs = null;
object persistedState = null;
var requestCount = 0;
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await InitializeConnectionAsync(async context =>
{
appTcs.TrySetResult();

requestCount++;
var persistentStateCollection = context.Features.Get<IPersistentStateFeature>().State;
if (persistentStateCollection.TryGetValue("Counter", out var value))
Expand All @@ -509,6 +516,9 @@ await InitializeConnectionAsync(async context =>
appDelegateTcs = new TaskCompletionSource();
await StartStreamAsync(1, _browserRequestHeaders, endStream: true);

// If app code is running we know the stream has been created
await appTcs.Task;
appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
// Get the in progress stream
var stream = _connection._streams[1];

Expand All @@ -534,6 +544,8 @@ await ExpectAsync(Http2FrameType.HEADERS,
appDelegateTcs = new TaskCompletionSource();
await StartStreamAsync(3, _browserRequestHeaders, endStream: true);

await appTcs.Task;

// New stream has been taken from the pool
Assert.Equal(0, _connection.StreamPool.Count);

Expand Down Expand Up @@ -564,9 +576,11 @@ public async Task StreamPool_StreamIsInvalidState_DontReturnedToPool()
{
// Add (or don't add) stream to Http2Connection._completedStreams inline with SetResult().
var serverTcs = new TaskCompletionSource();
var appTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

await InitializeConnectionAsync(async context =>
{
appTcs.TrySetResult();
await serverTcs.Task.DefaultTimeout();

await context.Response.WriteAsync("Content");
Expand All @@ -575,6 +589,8 @@ await InitializeConnectionAsync(async context =>

await StartStreamAsync(1, _browserRequestHeaders, endStream: true);

// If app code is running we know the stream has been created
await appTcs.Task;
var stream = _connection._streams[1];
serverTcs.SetResult();

Expand Down
Loading