Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Jan 16, 2025

No description provided.

@mmitche mmitche requested review from a team and wtgodbe as code owners January 16, 2025 22:25
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2025
<AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>

<!-- Suppress validation to avoid Applocker failures when running light.exe on dev machines. -->
<SuppressValidation>true</SuppressValidation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for the .sfxproj's in https://github.com/dotnet/aspnetcore/tree/main/src/Framework as well? I think this d.b.p is only used by the Hosting Bundle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need it for the wixprojs as far as I can tell. I think only ANCM, but I put it here since ANCM and the hosting bundle projects import this file

@mmitche
Copy link
Member Author

mmitche commented Jan 16, 2025

Confirmed this works.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn't work for me locally back then but if it now works, I'm happy.

@ViktorHofer ViktorHofer merged commit 9388d49 into dotnet:main Jan 17, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants