Compute dates in DefaultKeyResolver once #60051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the maximum activation and creation `DateTImeOffset` for `DefaultKeyResolver` once before executing a LINQ query, rather than for each evaluation of `where`.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
captainsafia
approved these changes
Jan 28, 2025
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Great change, @martincostello! Improves the readability of this code as well. 😄
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Compute the maximum activation and creation `DateTImeOffset` for `DefaultKeyResolver` once before executing a LINQ query, rather than for each evaluation of `where`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute dates in DefaultKeyResolver once
Compute dates in
DefaultKeyResolveronce per LINQ query.Description
Compute the maximum activation and creation
DateTimeOffsetforDefaultKeyResolveronce before executing a LINQ query, rather than for each evaluation ofwherein the query.Spotted while looking at #60049.