Package dotnet-getdocument from current TFM into top-level #60055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-commandlinetools
wtgodbe
approved these changes
Jan 27, 2025
Member
|
Are we missing a test here? |
Member
Author
Yes, we are. That's why the original issue slipped through. This document generation infrastructure is split up into an inner executable and a set of MSBuild targets that invoke that executable. We test the former, but not the later. I think the primarily reason for this is our SDK-based testing infrastructure in the repo is pretty weak. This is something that will hopefully improve with #58353. |
captainsafia
added a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60026.
In the previous PR, I removed the
netcoreapp2.0target based on TFM instruction and removed the packaging of it in the top-level. I didn't realize that the MSBuild targets associated with this package were still being used by theGetDocumenttool.I'm packaging the net10-targeted build for this tool in the top-level nuspec file to ensure that the
dotnet-getdocument.dllfile is available in thetoolsdirectory. I think the net10 target is the correct one to use here since the TFM and package version are associated.It would be good to squeeze this in before the 10-preview1 cut-off later today.