Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 4, 2025

Turn on static code analysis feature in SDL

Copilot AI review requested due to automatic review settings March 4, 2025 23:05
@wtgodbe wtgodbe requested a review from a team as a code owner March 4, 2025 23:05
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request enables a static code analysis pilot within the CI pipeline by adding new configuration flags.

  • Enables a new policy ("MicrosoftCanary")
  • Activates the prefast analysis with break enabled and sets its severity to CriticalError
  • Sets new feature flags for prefast versioning and enablement check

Reviewed Changes

File Description
.azure/pipelines/ci.yml New static code analysis settings added to the pipeline configuration

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.azure/pipelines/ci.yml:131

  • Verify that 'CriticalError' is an accepted value for severity. Some systems expect severity levels in a specific format, such as lowercase.
        severity: CriticalError

.azure/pipelines/ci.yml:134

  • [nitpick] Consider renaming 'checkIfEnablePrefast' to a more concise flag, such as 'enablePrefastCheck', to improve clarity and maintain consistency with similar flag naming.
        checkIfEnablePrefast: false

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 4, 2025

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 5, 2025

Internal build failed - working w/ the static analysis team to figure out a fix

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 13, 2025
@RussKie
Copy link
Contributor

RussKie commented Mar 21, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 21, 2025
@RussKie RussKie enabled auto-merge (squash) March 21, 2025 03:04
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 28, 2025
@wtgodbe wtgodbe closed this Jul 25, 2025
auto-merge was automatically disabled July 25, 2025 19:51

Pull request was closed

@wtgodbe wtgodbe deleted the wtgodbe/staticcodeanal branch July 25, 2025 19:51
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants