Skip to content

Conversation

@maraf
Copy link
Member

@maraf maraf commented Apr 11, 2025

Add placeholder that OverrideHtmlAssetPlaceholders=true feature overrides with link elements to WebAssembly assets to preload.

Contributes to #58875

@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Apr 11, 2025
@maraf maraf added this to the 10.0-preview4 milestone Apr 11, 2025
@maraf maraf self-assigned this Apr 11, 2025
@maraf maraf requested a review from a team as a code owner April 11, 2025 11:08
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>ComponentsWebAssembly-CSharp</title>
<base href="/" />
<link rel="preload" id="webassembly" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet-wasm ? dotnet-webassembly ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing the name would require changing the SDK side too. If we don't feel strongly about naming, I think going with webassembly is fine. (It's also more consistent with what we use elsewhere, where we just use webassembly if that helps)

Copy link
Member Author

@maraf maraf Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name already landed in different PR for "hosted" mode.
I probably wouldn't prefer dotnet- prefix as everything here is dotnet.
Whether wasm or webassembly is up for discussion.

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewing lewing closed this Apr 14, 2025
@lewing lewing reopened this Apr 14, 2025
@lewing lewing enabled auto-merge (squash) April 14, 2025 14:20
@lewing lewing merged commit f2d6a71 into dotnet:main Apr 14, 2025
28 checks passed
@maraf maraf deleted the BlazorWasmPreloadPlaceholderTemplate branch April 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants