Skip to content

Use NormalizeDirectory consistently in SiteExtensions D.B.P #61455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2025
Merged

Use NormalizeDirectory consistently in SiteExtensions D.B.P #61455

merged 3 commits into from
Apr 12, 2025

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 11, 2025

We were calculating paths using 2 different methods in this file. NormalizeDirectory is better, so centralize on that. Generated by CoPilot!

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Apr 11, 2025
@wtgodbe wtgodbe requested a review from Copilot April 11, 2025 16:26
Copilot AI reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/SiteExtensions/Directory.Build.props: Language not supported

rainersigwald
rainersigwald reviewed Apr 11, 2025
View reviewed changes
@wtgodbe wtgodbe enabled auto-merge (squash) April 11, 2025 17:10
@build-analysis build-analysis bot mentioned this pull request Apr 11, 2025
Closed
3 tasks
@wtgodbe wtgodbe merged commit d9c0bed into main Apr 12, 2025
27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/dbp branch April 12, 2025 10:57
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rainersigwald rainersigwald rainersigwald approved these changes

@danmoseley danmoseley danmoseley approved these changes

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

10.0-preview4

Development

Successfully merging this pull request may close these issues.

4 participants

@wtgodbe @rainersigwald @danmoseley