Skip to content

Retry Microsoft.AspNetCore.TargetingPackTests.TargetingPackContainsListedAssemblies #62390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Retry Microsoft.AspNetCore.TargetingPackTests.TargetingPackContainsListedAssemblies #62390

wants to merge 1 commit into from

Conversation

@radical
Copy link
Member

@radical radical commented Jun 18, 2025

…stedAssemblies

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@radical radical requested review from a team and wtgodbe as code owners June 18, 2025 06:42
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 18, 2025
BrennanConroy
BrennanConroy requested changes Jun 18, 2025
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test isn't flaky

@radical
Copy link
Member Author

radical commented Jun 18, 2025

This test isn't flaky

Closing this in favor of fixing the PR.

@wtgodbe
Copy link
Member

wtgodbe commented Jun 19, 2025

This test isn't flaky

Agreed, any failure in this test is real

@radical
Copy link
Member Author

radical commented Jun 19, 2025

This test isn't flaky

Agreed, any failure in this test is real

Oops, missing hitting the close button!

@radical radical closed this Jun 19, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy requested changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@radical @wtgodbe @BrennanConroy