Skip to content

Improve SSR navigation tests #62536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2025
Merged

Improve SSR navigation tests #62536

merged 3 commits into from
Jul 14, 2025

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 2, 2025 •
edited
Loading

Test redirection with and without NavigationException

Description

  • After flipping the switch, we did not set the newly added tests to use the new way of working. This PR sets the switch on them.
  • Old SSR redirection tests should be testing both: new and old way, at least until we make the new way (no exception) the default. This PR changes them from Fact to Theory with 2 options. It adds 16 new test cases. That includes the scenario that the issue mentions (RedirectEnhancedGetToInternal).
  • Adds a new test for the scenario from the issue, redirecting to a not found path.
  • Nit: changing the test names to include _ makes them easier to read.

Adding more tests in relation to #62519.

@ilonatommy ilonatommy self-assigned this Jul 2, 2025
@ilonatommy ilonatommy requested a review from a team as a code owner July 2, 2025 08:23
@ilonatommy ilonatommy added the area-blazor Includes: Blazor, Razor Components label Jul 2, 2025
@ilonatommy ilonatommy requested a review from javiercn July 2, 2025 08:24
@ilonatommy
Update RedirectionTest.cs
99f9cb8 
Remove multiple blank lines.
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 9, 2025
@ilonatommy ilonatommy closed this Jul 10, 2025
@ilonatommy ilonatommy reopened this Jul 10, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 10, 2025
@ilonatommy ilonatommy requested review from maraf and oroztocil July 11, 2025 17:01
@ilonatommy ilonatommy removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 11, 2025
oroztocil
oroztocil approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@oroztocil oroztocil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@ilonatommy ilonatommy merged commit 08cadfe into dotnet:main Jul 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oroztocil oroztocil oroztocil approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@maraf maraf Awaiting requested review from maraf

Assignees

@ilonatommy ilonatommy

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

10.0-preview7

Development

Successfully merging this pull request may close these issues.

2 participants

@ilonatommy @oroztocil