From 96757d543874dc200d45e5d59177236d05abb4bf Mon Sep 17 00:00:00 2001 From: Ben Hopkins Date: Tue, 15 Jul 2025 16:01:09 +0100 Subject: [PATCH 1/4] XML doc for generated public partial Program class --- .../src/SourceGenerators/PublicTopLevelProgramGenerator.cs | 7 ++++--- .../PublicTopLevelProgramGeneratorTests.cs | 5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs index 7e3f3eacd95d..1653b3af1a85 100644 --- a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs +++ b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs @@ -12,11 +12,12 @@ public class PublicProgramSourceGenerator : IIncrementalGenerator { private const string PublicPartialProgramClassSource = """ // -#pragma warning disable CS1591 +/// +/// Auto-generated public partial Program class for top-level statement apps +/// public partial class Program { } -#pragma warning restore CS1591 """; - + public void Initialize(IncrementalGeneratorInitializationContext context) { var internalGeneratedProgramClass = context.CompilationProvider.Select(static (compilation, cancellationToken) => diff --git a/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs b/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs index 173dfa7469f8..746e03751781 100644 --- a/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs +++ b/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs @@ -9,9 +9,10 @@ public class PublicTopLevelProgramGeneratorTests { private const string ExpectedGeneratedSource = """ // -#pragma warning disable CS1591 +/// +/// Auto-generated public partial Program class for top-level statement apps +/// public partial class Program { } -#pragma warning restore CS1591 """; [Fact] From 8b0fd5731648941cdfa5ea5812cbbbd1bb7863fd Mon Sep 17 00:00:00 2001 From: Ben Hopkins Date: Tue, 15 Jul 2025 16:18:04 +0100 Subject: [PATCH 2/4] Added a full stop --- .../src/SourceGenerators/PublicTopLevelProgramGenerator.cs | 2 +- .../SourceGenerators/PublicTopLevelProgramGeneratorTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs index 1653b3af1a85..554c3c50166d 100644 --- a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs +++ b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs @@ -13,7 +13,7 @@ public class PublicProgramSourceGenerator : IIncrementalGenerator private const string PublicPartialProgramClassSource = """ // /// -/// Auto-generated public partial Program class for top-level statement apps +/// Auto-generated public partial Program class for top-level statement apps. /// public partial class Program { } """; diff --git a/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs b/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs index 746e03751781..a75a34057fd9 100644 --- a/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs +++ b/src/Framework/AspNetCoreAnalyzers/test/SourceGenerators/PublicTopLevelProgramGeneratorTests.cs @@ -10,7 +10,7 @@ public class PublicTopLevelProgramGeneratorTests private const string ExpectedGeneratedSource = """ // /// -/// Auto-generated public partial Program class for top-level statement apps +/// Auto-generated public partial Program class for top-level statement apps. /// public partial class Program { } """; From 67cd7c3dfbd97d594b0cc6c27489a3347884ce5a Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Tue, 15 Jul 2025 08:31:17 -0700 Subject: [PATCH 3/4] Update src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs --- .../src/SourceGenerators/PublicTopLevelProgramGenerator.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs index 554c3c50166d..8c97004bb1fa 100644 --- a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs +++ b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs @@ -17,7 +17,6 @@ public class PublicProgramSourceGenerator : IIncrementalGenerator /// public partial class Program { } """; - public void Initialize(IncrementalGeneratorInitializationContext context) { var internalGeneratedProgramClass = context.CompilationProvider.Select(static (compilation, cancellationToken) => From 80d427ee956433434bd5a60128285c6967a9e340 Mon Sep 17 00:00:00 2001 From: Ben Hopkins Date: Tue, 15 Jul 2025 17:54:01 +0100 Subject: [PATCH 4/4] Readded the removed line --- .../src/SourceGenerators/PublicTopLevelProgramGenerator.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs index 8c97004bb1fa..77b95a4b5070 100644 --- a/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs +++ b/src/Framework/AspNetCoreAnalyzers/src/SourceGenerators/PublicTopLevelProgramGenerator.cs @@ -17,6 +17,7 @@ public class PublicProgramSourceGenerator : IIncrementalGenerator /// public partial class Program { } """; + public void Initialize(IncrementalGeneratorInitializationContext context) { var internalGeneratedProgramClass = context.CompilationProvider.Select(static (compilation, cancellationToken) =>