From bb345fb06baf96a29089b2e58b9dd29ae6de72b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Rozto=C4=8Dil?= Date: Thu, 11 Sep 2025 17:43:55 +0200 Subject: [PATCH 1/2] Quarantine ProcessBufferedRenderBatches_WritesRenders --- .../Server/test/Circuits/RemoteRendererTest.cs | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/Components/Server/test/Circuits/RemoteRendererTest.cs b/src/Components/Server/test/Circuits/RemoteRendererTest.cs index 73af5c13651c..eddc845b90da 100644 --- a/src/Components/Server/test/Circuits/RemoteRendererTest.cs +++ b/src/Components/Server/test/Circuits/RemoteRendererTest.cs @@ -9,6 +9,7 @@ using Microsoft.AspNetCore.Components.Server; using Microsoft.AspNetCore.Components.Server.Circuits; using Microsoft.AspNetCore.DataProtection; +using Microsoft.AspNetCore.InternalTesting; using Microsoft.AspNetCore.SignalR; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; @@ -126,6 +127,7 @@ public async Task ProducesNewBatch_WhenABatchGetsAcknowledged() } [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/61807")] public async Task ProcessBufferedRenderBatches_WritesRenders() { // Arrange @@ -767,6 +769,17 @@ public Task SetParametersAsync(ParameterView parameters) public void TriggerRender() { var task = _renderHandle.Dispatcher.InvokeAsync(() => _renderHandle.Render(_renderFragment)); + + // TODO: Remove the following block once ProcessBufferedRenderBatches_WritesRenders is fixed. + if (!task.IsCompletedSuccessfully) + { + // Log the task state for debugging purposes. + var status = task.Status; + var innerException = task.Exception?.InnerException; + var message = $"Render task should succeed synchronously.\nStatus: '{status}'\nInner exception: '{innerException}'"; + Assert.True(task.IsCompletedSuccessfully, message); + } + Assert.True(task.IsCompletedSuccessfully); } } From 6791918daace3198e6988d89f94a6c4e201763d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Rozto=C4=8Dil?= Date: Fri, 12 Sep 2025 12:11:02 +0200 Subject: [PATCH 2/2] Simplify failed task logging in RemoteRendererTest --- .../Server/test/Circuits/RemoteRendererTest.cs | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/Components/Server/test/Circuits/RemoteRendererTest.cs b/src/Components/Server/test/Circuits/RemoteRendererTest.cs index eddc845b90da..92839155eb42 100644 --- a/src/Components/Server/test/Circuits/RemoteRendererTest.cs +++ b/src/Components/Server/test/Circuits/RemoteRendererTest.cs @@ -770,17 +770,12 @@ public void TriggerRender() { var task = _renderHandle.Dispatcher.InvokeAsync(() => _renderHandle.Render(_renderFragment)); - // TODO: Remove the following block once ProcessBufferedRenderBatches_WritesRenders is fixed. - if (!task.IsCompletedSuccessfully) - { - // Log the task state for debugging purposes. - var status = task.Status; - var innerException = task.Exception?.InnerException; - var message = $"Render task should succeed synchronously.\nStatus: '{status}'\nInner exception: '{innerException}'"; - Assert.True(task.IsCompletedSuccessfully, message); - } + // Log the task state for debugging purposes. + var status = task.Status; + var innerException = task.Exception?.InnerException; + var message = $"Render task should succeed synchronously.\nStatus: '{status}'\nInner exception: '{innerException}'"; - Assert.True(task.IsCompletedSuccessfully); + Assert.True(task.IsCompletedSuccessfully, message); } }