Rule rename

Shorten the rule names to be more about the scenario than the specific
action they are taking.

Author: jaredpar

src/CodeFormatter.sln

@@ -14,6 +14,11 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{34034F
 		.nuget\packages.config = .nuget\packages.config
 	EndProjectSection
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{297488BF-08A5-4D06-A0C3-B1623F49162A}"
+	ProjectSection(SolutionItems) = preProject
+		Performance1.psess = Performance1.psess
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -36,4 +41,7 @@ Global
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
+	GlobalSection(Performance) = preSolution
+		HasPerformanceSessions = true
+	EndGlobalSection
 EndGlobal

src/Microsoft.DotNet.CodeFormatting.Tests/Microsoft.DotNet.CodeFormatting.Tests.csproj

@@ -112,7 +112,7 @@
     <Compile Include="Rules\HasNewLineBeforeFirstUsingFormattingRuleTests.cs" />
     <Compile Include="Rules\HasNoNewLineAfterOpenBraceFormattingRuleTests.cs" />
     <Compile Include="Rules\HasNoNewLineBeforeEndBraceFormattingRuleTests.cs" />
-    <Compile Include="Rules\HasUnderScoreInPrivateFieldNamesFormattingRuleTests.cs" />
+    <Compile Include="Rules\PrivateFieldNamingRuleTests.cs" />
     <Compile Include="Rules\NonAsciiCharactersAreEscapedInLiteralsRuleTests.cs" />
     <Compile Include="Rules\UsesXunitForTestsFormattingRuleTests.cs" />
   </ItemGroup>

src/Microsoft.DotNet.CodeFormatting.Tests/Rules/HasUnderScoreInPrivateFieldNamesFormattingRuleTests.cs renamed to src/Microsoft.DotNet.CodeFormatting.Tests/Rules/PrivateFieldNamingRuleTests.cs

@@ -5,7 +5,7 @@
 
 namespace Microsoft.DotNet.CodeFormatting.Tests
 {
-    public class HasUnderScoreInPrivateFieldNamesFormattingRuleTests : CodeFormattingTestBase
+    public class PrivateFieldNamingRuleTests : CodeFormattingTestBase
     {
         [Fact]
         public void TestUnderScoreInPrivateFields()
@@ -45,7 +45,7 @@ class T
 
         internal override IFormattingRule GetFormattingRule()
         {
-            return new Rules.HasUnderScoreInPrivateFieldNamesFormattingRule();
+            return new Rules.PrivateFieldNamingRule();
         }
     }
 }

src/Microsoft.DotNet.CodeFormatting/Microsoft.DotNet.CodeFormatting.csproj

@@ -89,7 +89,7 @@
     <Compile Include="Rules\HasNoNewLineAfterOpenBraceFormattingRule.cs" />
     <Compile Include="Rules\HasNoNewLineBeforeEndBraceFormattingRule.cs" />
     <Compile Include="Rules\HasNoCustomCopyrightHeaderFormattingRule.cs" />
-    <Compile Include="Rules\HasUnderScoreInPrivateFieldNamesFormattingRule.cs" />
+    <Compile Include="Rules\PrivateFieldNamingRule.cs" />
     <Compile Include="Rules\HasUsingsOutsideOfNamespaceFormattingRule.cs" />
     <Compile Include="Rules\IsFormattedFormattingRule.cs" />
     <Compile Include="Rules\IsSimplifiedFormattingRule.cs" />

src/Microsoft.DotNet.CodeFormatting/Rules/HasUnderScoreInPrivateFieldNamesFormattingRule.cs renamed to src/Microsoft.DotNet.CodeFormatting/Rules/PrivateFieldNamingRule.cs

@@ -17,12 +17,23 @@
 
 namespace Microsoft.DotNet.CodeFormatting.Rules
 {
-    [RuleOrder(RuleOrder.HasUnderScoreInPrivateFieldNamesFormattingRule)]
+    [RuleOrder(RuleOrder.PrivateFieldNamingRule)]
     // TODO Bug 1086632: Deactivated due to active bug in Roslyn.
     // There is a hack to run this rule, but it's slow. 
     // If needed, enable the rule and enable the hack at the code below in RenameFields.
-    internal sealed class HasUnderScoreInPrivateFieldNamesFormattingRule : IFormattingRule
+    internal sealed class PrivateFieldNamingRule : IFormattingRule
     {
+        /// <summary>
+        /// This rewriter exists to work around DevDiv 1086632 in Roslyn.  The Rename action is 
+        /// leaving a set of annotations in the tree.  These annotations slow down further processing
+        /// and eventually make the rename operation unusable.  As a temporary work around we manually
+        /// remove these from the tree.
+        /// </summary>
+        private sealed class RemoveRenameAnnotationsRewriter : CSharpSyntaxRewriter
+        {
+
+        }
+
         private static string[] s_keywordsToIgnore = { "public", "internal", "protected", "const" };
         private static readonly SyntaxAnnotation s_annotationMarker = new SyntaxAnnotation();
         private static readonly Regex s_regex = new Regex("^._");

src/Microsoft.DotNet.CodeFormatting/Rules/RuleOrder.cs

@@ -21,7 +21,7 @@ internal static class RuleOrder
         public const int HasNoNewLineBeforeEndBraceFormattingRule = 7;
         public const int HasNoNewLineAfterOpenBraceFormattingRule = 8;
         public const int ExplicitVisibilityRule = 9;
-        public const int HasUnderScoreInPrivateFieldNamesFormattingRule = 10;
+        public const int PrivateFieldNamingRule = 10;
         public const int IsFormattedFormattingRule = 11;
         public const int UsesXunitForTestsFormattingRule = 12;
         public const int NonAsciiChractersAreEscapedInLiterals = 13;