Merge pull request #800 from jonsequitur/add-test-for-799

add a test for #798 / #799

Author: jonsequitur

src/System.CommandLine.Tests/Binding/ModelBindingCommandHandlerTests.cs

@@ -132,6 +132,30 @@ await handler.InvokeAsync(
             console.Out.ToString().Should().Be($"ClassWithCtorParameter<{type.Name}>: {expectedValue}");
         }
 
+        [Fact]
+        public void When_name_is_not_among_aliases_then_binder_will_bind_option_by_name()
+        {
+            var rootCommand = new RootCommand
+            {
+                new Option("-n")
+                {
+                    Argument = new Argument<string[]>("header"),
+                    Name = "name"
+                }
+            };
+
+            string[] receivedHeaders = null;
+
+            rootCommand.Handler = CommandHandler.Create((string[] name) =>
+            {
+                receivedHeaders = name;
+            });
+
+            rootCommand.Invoke("-n one -n two");
+
+            receivedHeaders.Should().BeEquivalentTo("one", "two");
+        }
+      
         [Theory]
         [InlineData(typeof(string), "hello", "hello")]
         [InlineData(typeof(int), "123", 123)]

src/System.CommandLine.Tests/OptionTests.cs

@@ -1,24 +1,15 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System.CommandLine.Invocation;
 using System.CommandLine.Parsing;
 using System.Linq;
 using FluentAssertions;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace System.CommandLine.Tests
 {
     public class OptionTests : SymbolTests
     {
-        private ITestOutputHelper _output;
-
-        public OptionTests(ITestOutputHelper output)
-        {
-            _output = output;
-        }
-
         [Fact]
         public void When_an_option_has_only_one_alias_then_that_alias_is_its_name()
         {
@@ -343,7 +334,7 @@ public void Option_T_default_value_is_validated()
                 .BeEquivalentTo(new[] { "ERR" });
 
         }
-
+   
         protected override Symbol CreateSymbol(string name) => new Option(name);
     }
 }